Make OMIClient async. #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is made to support running both as a Python script as well as in a Jupyter notebook. Since Jupyter uses IPython as the runtime, we cannot use the `asyncio` methods to try and run async functions outside of a larger event loop. This change adds a tiny bit of complexity to using the OMIClient but it should be familiar to anyone who's used async/await in Python.
bmunday3
approved these changes
Oct 26, 2023
n8mellis
added a commit
that referenced
this pull request
Nov 15, 2023
* Make OMIClient async. This change is made to support running both as a Python script as well as in a Jupyter notebook. Since Jupyter uses IPython as the runtime, we cannot use the `asyncio` methods to try and run async functions outside of a larger event loop. This change adds a tiny bit of complexity to using the OMIClient but it should be familiar to anyone who's used async/await in Python. * Updated docs with new async OMIClient. # Conflicts: # docs/docs/getting-started/index.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is made to support running both as a Python script as well as in a Jupyter notebook.
Since Jupyter uses IPython as the runtime, we cannot use the
asynciomethods to try and run async functions outside of a larger event loop.This change adds a tiny bit of complexity to using the OMIClient but it should be familiar to anyone who's used async/await in Python.