Heroku hotfix https://stackoverflow.com/a/73273766/2161301 #789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Code Climate has analyzed commit 3a0e65a and detected 0 issues on this pull request. View more on Code Climate. |
|
Hi, thanks for this contribution; I would prefer to add this patch, though, as it seems more concise, https://stackoverflow.com/a/73289426/1542304 |
|
Hey, I will close this PR since despite the deploy working with the script you have linked, everything else doesn't seem work and I don't want to PR a potentially breaking change without being able to confirm stability. No idea if it's just us misunderstanding the instructions or if the instructions are missing crucial steps but at this point I've spent almost a week trying to get this to run and I will probably look for commercial solutions from here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #788, Heroku has made some breaking changes on August 1st .
@joelbiffin has pointed to a solution at https://stackoverflow.com/a/73273766/2161301 and the error did disappear.
Idk if Heroku needs to fix stuff in their servers or if that will be the expected behavior now but this PR adds an additional script to reflect the changes Heroku expects now.