Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

full-clickable-cards-and-collections #523

Open
wants to merge 2,020 commits into
base: master
Choose a base branch
from

Conversation

laurentUbik
Copy link
Contributor

Hello,

Here is a proposal to modify the cards and collections in order to make them fully clickable rather than just the title in hyperlink.

Coming from Angular and unfamiliar with ReactJs (and their way of doing things seems so different!) Don't hesitate if I make a mistake.

Tested on app selection, collections, collections with sections and articles.

chaskiq-clickable-cards

michelson and others added 30 commits October 27, 2020 02:35
Fix missing import of DeleteDialog to be able to delete articles.
skip if app blank on subscription hook
segments with tag support + search conversations
michelson and others added 25 commits September 19, 2021 20:31
* New translations en.yml (Italian)

* New translations en.yml (Italian)
* update integration fields, relax attributes

* messaging channel support

* Dialogflow process only from non-assignee or bot agent assignee
* translations

* docs image renderer alignment + header image bg size cover

* format
* home panel disabled conversation display fix
* home panel disabled conversation display fix
* chaskiq plugin gen
* boring avatars

* enable i18n fallback
* boring avatars

* enable i18n fallback

* liltle refactor + fix on colorPicker
* New translations en.yml (Italian)

* New translations en.yml (Serbian (Cyrillic))

* New translations en.yml (Russian)

* New translations en.yml (Swedish)

* New translations en.yml (Norwegian)

* New translations en.yml (Polish)

* New translations en.yml (Portuguese)

* New translations en.yml (Vietnamese)

* New translations en.yml (English)

* New translations en.yml (Persian)

* New translations en.yml (Turkish)

* New translations en.yml (Ukrainian)

* New translations en.yml (Chinese Simplified)

* New translations en.yml (Romanian)

* New translations en.yml (German)

* New translations en.yml (Danish)

* New translations en.yml (Greek)

* New translations en.yml (French)

* New translations en.yml (Spanish)

* New translations en.yml (Afrikaans)

* New translations en.yml (Arabic)

* New translations en.yml (Catalan)

* New translations en.yml (Czech)

* New translations en.yml (Dutch)

* New translations en.yml (Japanese)

* New translations en.yml (Korean)

* New translations en.yml (Finnish)

* New translations en.yml (Hebrew)

* New translations en.yml (Hungarian)
The bot tasks didn't appear in the list after beeing disabled.
* New translations definitions.en.yml (Afrikaans)

* New translations en.yml (Afrikaans)

* New translations en.yml (French)

* New translations definitions.en.yml (French)

* New translations en.yml (French)
Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.12.2 to 1.12.5.
- [Release notes](https://github.com/sparklemotion/nokogiri/releases)
- [Changelog](https://github.com/sparklemotion/nokogiri/blob/main/CHANGELOG.md)
- [Commits](sparklemotion/nokogiri@v1.12.2...v1.12.5)

---
updated-dependencies:
- dependency-name: nokogiri
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* i18n fallback true on messenger

* translations gen
* translations

* gen first stage

* chaskiq plugin gen

* logos, + zap

* format

* provider update

* zap spec

* zapier triggers conversations & contact

* update specific pkg on spec

* api user display name & api handle new conversation

* format

* translations

* translations

* auth specs
* validations & formats on zaps
* fix translations typo on availability

* Editor tweaks and fix file link on Drat renderer
* Update AssignmentRules.tsx

* Update edit_assign_rule.rb

* Update create_assign_rule.rb

* Update mutations.ts

Co-authored-by: Nuxor3000 <72187088+Nuxor3000@users.noreply.github.com>
Bumps [sidekiq](https://github.com/mperham/sidekiq) from 6.1.2 to 6.2.1.
- [Release notes](https://github.com/mperham/sidekiq/releases)
- [Changelog](https://github.com/mperham/sidekiq/blob/main/Changes.md)
- [Commits](sidekiq/sidekiq@v6.1.2...v6.2.1)

---
updated-dependencies:
- dependency-name: sidekiq
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@codeclimate
Copy link

codeclimate bot commented Oct 12, 2021

Code Climate has analyzed commit c38c0ca and detected 0 issues on this pull request.

View more on Code Climate.

@michelson
Copy link
Member

thanks for this PR @laurentUbik, very useful contribution.
I will try to merge this asap

@laurentUbik
Copy link
Contributor Author

ahah not that useful but it allows me to start somewhere ^^

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 5 committers have signed the CLA.

✅ michelson
❌ Nuxor3000
❌ olimart
❌ dependabot[bot]
❌ laurentUbik
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants