Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add hsl and hsla functions #141

Merged
merged 3 commits into from
May 3, 2024
Merged

feat: add hsl and hsla functions #141

merged 3 commits into from
May 3, 2024

Conversation

bsushmith
Copy link
Contributor

Closes: #140

@bsushmith bsushmith mentioned this pull request Apr 29, 2024
Closed
chasefleming
chasefleming requested changes Apr 30, 2024
View reviewed changes
Copy link
Owner

@chasefleming chasefleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this one! Much appreciated. Left a couple comments. Also, two more items:

  • Can you update the tests please so the comments would have be caught?
  • Can you use strconv.Itoa instead of strconv.FormatInt like RBGA?

Thanks!

styles/utils.go Outdated Show resolved Hide resolved
styles/utils.go Outdated Show resolved Hide resolved
styles/utils.go Outdated Show resolved Hide resolved
styles/utils.go Outdated Show resolved Hide resolved
@bsushmith
Copy link
Contributor Author

Thanks for the feedback!

  • Can you use strconv.Itoa instead of strconv.FormatInt like RBGA?

I have used strconv.FormatInt since that seemed to be slightly faster than strconv.Itoa. What would you suggest?

@chasefleming
Copy link
Owner

@bsushmith Ok, I'm good with that then. Thanks for sharing.

chasefleming
chasefleming approved these changes May 3, 2024
View reviewed changes
Copy link
Owner

@chasefleming chasefleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for grabbing this one!

@chasefleming chasefleming merged commit 3c09cdd into chasefleming:main May 3, 2024
1 check passed
@bsushmith bsushmith deleted the add/hsl_hsla branch May 21, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chasefleming chasefleming chasefleming approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add hsl and hsla Function Implementations
2 participants
@bsushmith @chasefleming