Fix Facade Task Signature to Take repo_git instead of repo_id
#2775
+23
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…contraints Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
Add Check to SQL Update Statements to Avoid constraints on `date_last_collected`
Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -194,14 +194,22 @@ def link_commits_to_contributor(session,contributorQueue): | |||
|
|
|||
| # Update the contributors table from the data facade has gathered. | |||
| @celery.task(base=AugurFacadeRepoCollectionTask, bind=True) | |||
| def insert_facade_contributors(self, repo_id): | |||
| def insert_facade_contributors(self, repo_git): | |||
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
R1711: Useless return at end of function or method (useless-return)
| @@ -194,14 +194,22 @@ def link_commits_to_contributor(session,contributorQueue): | |||
|
|
|||
| # Update the contributors table from the data facade has gathered. | |||
| @celery.task(base=AugurFacadeRepoCollectionTask, bind=True) | |||
| def insert_facade_contributors(self, repo_id): | |||
| def insert_facade_contributors(self, repo_git): | |||
|
|
|||
| engine = self.app.engine | |||
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
W0612: Unused variable 'engine' (unused-variable)
sgoggins
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Facade task error handling expects each facade task to have the repo url as the first argument passed to the task. Otherwise it can cause unintended behavior.
To fix I altered the facade task signature to match the expected function signature and have
repo_gitas the first argument.Signed commits