New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add french language support #226
base: master
Are you sure you want to change the base?
Add french language support #226
Conversation
Remove Make a new Pull Request without |
Remove composer.lock and composer.json files from the Pull Request
Remove composer.lock and composer.json files from the Pull Request
@@ -78,7 +78,17 @@ | |||
| | |||
*/ | |||
|
|||
'locale' => 'en', | |||
//'locale' => 'en', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should not change locale to 'fr', as this will change it for everyone.
you can modify it for your project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a good idea here is to make the value an environment variable, on this way the people who wants to use the project don't need to touch this file, only the .env
@@ -91,7 +101,7 @@ | |||
| | |||
*/ | |||
|
|||
'fallback_locale' => 'en', | |||
'fallback_locale' => 'fr', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some "resources/lang/*.php" has mistranslations.
Most of all had spanish strings - NOT arabic or french like title say so.
This PR shouldn't be approved!
| | ||
*/ | ||
|
||
'failed' => 'Credenciales invalidas. Verifique e intente nuevamente.', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This content is NOT arabic.
It's spanish!
| | ||
*/ | ||
|
||
'password' => 'Las contraseñas deben ser de al menos 6 letras y coincidir entre ellas.', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This content is NOT arabic.
It's Spanish!
| | ||
*/ | ||
|
||
'accepted' => 'El :attribute debe ser aceptado.', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This content is NOT arabic.
It's Spanish!
| | ||
*/ | ||
|
||
'failed' => 'Credenciales invalidas. Verifique e intente nuevamente.', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This content is NOT arabic or french.
It's Spanish!
| | ||
*/ | ||
|
||
'previous' => '« Anterior', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This content is NOT arabic or french.
It's Spanish!
| | ||
*/ | ||
|
||
'password' => 'Las contraseñas deben ser de al menos 6 letras y coincidir entre ellas.', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This content is NOT arabic or french.
It's Spanish!
| | ||
*/ | ||
|
||
'accepted' => 'El :attribute debe ser aceptado.', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This content is NOT arabic or french.
It's Spanish!
Hello,
this version does not contain the french language, I added the french language and the arabic language to the project.