Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add french language support #226

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

MahmoudDevo
Copy link

Hello,
this version does not contain the french language, I added the french language and the arabic language to the project.

@changeweb
Copy link
Owner

Remove composer.lock and composer.json files from the Pull Request. The build is failing due to package version conflict.

Make a new Pull Request without composer.lock and composer.json files.

Remove composer.lock and composer.json files from the Pull Request
Remove composer.lock and composer.json files from the Pull Request
@@ -78,7 +78,17 @@
|
*/

'locale' => 'en',
//'locale' => 'en',
Copy link

@pateash pateash Nov 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should not change locale to 'fr', as this will change it for everyone.
you can modify it for your project.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a good idea here is to make the value an environment variable, on this way the people who wants to use the project don't need to touch this file, only the .env

@@ -91,7 +101,7 @@
|
*/

'fallback_locale' => 'en',
'fallback_locale' => 'fr',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here.

Copy link

@asathler asathler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some "resources/lang/*.php" has mistranslations.
Most of all had spanish strings - NOT arabic or french like title say so.

This PR shouldn't be approved!

|
*/

'failed' => 'Credenciales invalidas. Verifique e intente nuevamente.',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This content is NOT arabic.
It's spanish!

|
*/

'password' => 'Las contraseñas deben ser de al menos 6 letras y coincidir entre ellas.',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This content is NOT arabic.
It's Spanish!

|
*/

'accepted' => 'El :attribute debe ser aceptado.',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This content is NOT arabic.
It's Spanish!

|
*/

'failed' => 'Credenciales invalidas. Verifique e intente nuevamente.',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This content is NOT arabic or french.
It's Spanish!

|
*/

'previous' => '« Anterior',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This content is NOT arabic or french.
It's Spanish!

|
*/

'password' => 'Las contraseñas deben ser de al menos 6 letras y coincidir entre ellas.',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This content is NOT arabic or french.
It's Spanish!

|
*/

'accepted' => 'El :attribute debe ser aceptado.',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This content is NOT arabic or french.
It's Spanish!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants