New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 3 Letter Country Codes #576
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There some formatting side effects in the test. Can you restore it so that only lines 182-187 are affected?
Let me do that. It just the way my IDE is set up. It removes whitespace. |
@somejeff I fixed it. Thanks for the reply. |
On the topic of country codes, why not use https://github.com/chancejs/chance-iso3166? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good job
Allows a user to request a 3-letter country code.
chance.country({ alpha3: true })