Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 3 Letter Country Codes #576

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

nicballesteros
Copy link

Allows a user to request a 3-letter country code.
chance.country({ alpha3: true })

Copy link
Contributor

@somejeff somejeff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There some formatting side effects in the test. Can you restore it so that only lines 182-187 are affected?

@nicballesteros
Copy link
Author

Let me do that. It just the way my IDE is set up. It removes whitespace.

@nicballesteros
Copy link
Author

@somejeff I fixed it. Thanks for the reply.

@leesei
Copy link
Contributor

leesei commented May 10, 2023

On the topic of country codes, why not use https://github.com/chancejs/chance-iso3166?
Externing it will reduce the file size of chance.js and have better modularization?

Copy link

@AbdullahWins AbdullahWins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants