Remove vuex from some document components #5432
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Set warning about using api.js
…mens # Conflicts: # assets/vue/components/documents/FormNewDocument.vue
daniboygg
commented
Apr 25, 2024
| getterType: "documents/getField", | ||
| mutationType: "documents/updateField", | ||
| }) | ||
|
|
||
| export default { | ||
| name: "DocumentsCreateFile", | ||
| servicePrefix, |
There was a problem hiding this comment.
What is the purpose of this line servicePrefix? It's defined above const servicePrefix = "Documents"
daniboygg
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5432 +/- ##
=========================================
Coverage 40.21% 40.21%
Complexity 10328 10328
=========================================
Files 818 818
Lines 43434 43434
=========================================
Hits 17465 17465
Misses 25969 25969 ☔ View full report in Codecov by Sentry. |
|
Code Climate has analyzed commit fa2571a and detected 0 issues on this pull request. View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5377