Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C2] Migrate from vuex to pinia is system announcement #5387

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

daniboygg
Copy link
Contributor

@daniboygg daniboygg commented Apr 17, 2024

Fix issue with router, because announcement is not in vue we need to use the location api from browser instead of vue router

#5377

* Fix issue with router, because announcement is not in vue we need to
use the location api from browser instead of vue router
Copy link

codecov bot commented Apr 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.32%. Comparing base (f9eb947) to head (5877d73).
Report is 56 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5387      +/-   ##
============================================
- Coverage     40.77%   39.32%   -1.46%     
- Complexity    10214    10275      +61     
============================================
  Files           807      814       +7     
  Lines         42433    43543    +1110     
============================================
- Hits          17304    17125     -179     
- Misses        25129    26418    +1289     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codeclimate bot commented Apr 17, 2024

Code Climate has analyzed commit 5877d73 and detected 0 issues on this pull request.

View more on Code Climate.

@ywarnier ywarnier merged commit c672491 into chamilo:master Apr 23, 2024
5 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants