-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt glossary to vue - refs 4768 #4789
Merged
AngelFQC
merged 21 commits into
chamilo:master
from
daniboygg:gh-4768-adapt-glossary-to-vue
Jul 6, 2023
Merged
Adapt glossary to vue - refs 4768 #4789
AngelFQC
merged 21 commits into
chamilo:master
from
daniboygg:gh-4768-adapt-glossary-to-vue
Jul 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add prettier github action to check vue files * Add prettier tailwind plugin * Remove semicolons with prettier rule
* Delete from main.js since it is not used in any place without importing the component * Use this layout to link and glossary pages
* Add missing icons in ChamiloIcons.js. Disable eslint to this class otherwise automatically remove quotes on some word and looks incosistent
* Split table and list term visualization in 2 different components * Extract api code to glossaryService
* Define button type validator to reuse * Fix glossary service delete endpoint
* Create button layout to reuse across forms * Create generic layout for forms to when create and edit items
* Refactor Links update with new components for consistency
* Extract api calls to glossary service
Code Climate has analyzed commit 0c6e1b0 and detected 0 issues on this pull request. View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement new components in glossary interface #4768