Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add time-picker #1415

Merged
merged 20 commits into from May 20, 2024
Merged

Conversation

colinlienard
Copy link
Contributor

@colinlienard colinlienard commented Apr 10, 2024

📝 Description

Add a TimePicker component

🚀 New behavior

  • Input with the value as a string
  • Trigger to open a menu
  • Choose an hour, a minute and a period (for specific locales) in the menu

💣 Is this a breaking change (Yes/No):

No

📝 Additional Information

  • Basic logic
  • Complete API
    • Clearable
    • Disabled
    • Seconds
    • Steps
    • Min/max hours/minutes
  • Props
  • Handle locale
  • Accessibility
  • Examples
  • Docs
  • Tests

Copy link

changeset-bot bot commented Apr 10, 2024

⚠️ No Changeset found

Latest commit: 1bec95b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Apr 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
zag-nextjs ✅ Ready (Inspect) Visit Preview May 20, 2024 2:29pm
zag-solid ✅ Ready (Inspect) Visit Preview May 20, 2024 2:29pm
zag-svelte ✅ Ready (Inspect) Visit Preview May 20, 2024 2:29pm
zag-vue ✅ Ready (Inspect) Visit Preview May 20, 2024 2:29pm
zag-website ✅ Ready (Inspect) Visit Preview May 20, 2024 2:29pm

@segunadebayo
Copy link
Member

segunadebayo commented May 20, 2024

@colinlienard @pierresisson Took the time to refactor the machine and API to be consistent with the other machines. I figured we might not merge this soon enough if I had to send a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants