Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING: add preset name mandatory key #2372

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

astahmer
Copy link
Collaborator

@astahmer astahmer commented Mar 12, 2024

📝 Description

Add a name mandatory key in Preset to make it easy to target one specifically

💣 Is this a breaking change (Yes/No):

yes. types will throw.
the runtime is not affected YET. we'll make use of that preset name soon and things might break at this point if you haven't added one.


simplify the internal logic of merging config/presets

Copy link

changeset-bot bot commented Mar 12, 2024

🦋 Changeset detected

Latest commit: c22a40c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 20 packages
Name Type
@pandacss/types Minor
@pandacss/dev Minor
@pandacss/config Minor
@pandacss/core Minor
@pandacss/fixture Minor
@pandacss/generator Minor
@pandacss/logger Minor
@pandacss/node Minor
@pandacss/parser Minor
@pandacss/preset-atlaskit Minor
@pandacss/preset-base Minor
@pandacss/preset-open-props Minor
@pandacss/preset-panda Minor
@pandacss/studio Minor
@pandacss/token-dictionary Minor
@pandacss/postcss Minor
@pandacss/astro-plugin-studio Minor
@pandacss/extractor Minor
@pandacss/is-valid-prop Minor
@pandacss/shared Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Mar 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
panda-docs ✅ Ready (Inspect) Visit Preview Mar 15, 2024 0:55am
panda-playground ✅ Ready (Inspect) Visit Preview Mar 15, 2024 0:55am
panda-studio ✅ Ready (Inspect) Visit Preview Mar 15, 2024 0:55am

@astahmer astahmer marked this pull request as draft March 12, 2024 00:20
@astahmer astahmer marked this pull request as ready for review March 14, 2024 23:30
@astahmer astahmer force-pushed the chore/mandatory-preset-name branch from 093bc1a to 0675e13 Compare March 14, 2024 23:30
@astahmer astahmer force-pushed the chore/mandatory-preset-name branch from 0675e13 to 17ddf1a Compare March 15, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant