New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BREAKING: add preset name
mandatory key
#2372
Open
astahmer
wants to merge
4
commits into
main
Choose a base branch
from
chore/mandatory-preset-name
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c22a40c The changes in this PR will be included in the next version bump. This PR includes changesets to release 20 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
astahmer
force-pushed
the
chore/mandatory-preset-name
branch
from
March 14, 2024 23:30
093bc1a
to
0675e13
Compare
astahmer
force-pushed
the
chore/mandatory-preset-name
branch
from
March 15, 2024 09:52
0675e13
to
17ddf1a
Compare
it now follows a left-to-right order just like in the config.presets, making it much easier to reason about
astahmer
force-pushed
the
chore/mandatory-preset-name
branch
from
March 15, 2024 12:16
17ddf1a
to
c22a40c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Add a
name
mandatory key inPreset
to make it easy to target one specifically💣 Is this a breaking change (Yes/No):
yes. types will throw.
the runtime is not affected YET. we'll make use of that preset name soon and things might break at this point if you haven't added one.
simplify the internal logic of merging config/presets