-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
setup-kind action: add feature-gates input #346
base: main
Are you sure you want to change the base?
setup-kind action: add feature-gates input #346
Conversation
Just to clarify, I've used a comma-separated value for - name: Not possible
uses: norbjd/actions/setup-kind@add-feature-gates-to-setup-kind
with:
# ...
feature-gates:
- InPlacePodVerticalScaling
- HPAScaleToZero
- ConsistentListFromCache Tell me if I'm wrong though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks so much for this
can you please update the documentation?
Hello 馃憢 Sorry about the late reply. I've added some documentation in the Anyway, I hope this is clear enough 馃榿 otherwise feel free to propose me something and I'll gladly add it. Thanks! |
Hello @cpanato, just a kind up 馃槆 Are you happy with the last changes? Otherwise, feel free to tell me! Thanks 馃檪 |
Hello 馃憢
First, thanks for the
setup-kind
action, it's very useful to remove boilerplate in all repositories requiring KinD.For one of my projects, I was missing the
featureGates
parameter in my KinD config with this action. This is something possible (see docs about feature gates), so I've decided to add it here and contribute upstream to also benefit others.With this change, we can define one or multiple (or zero) feature gates, separated by commas:
And this will create a KinD config with these feature gates enabled:
I have created a test repository using this action to see if my change works correctly: https://github.com/norbjd/test-setup-kind-action/blob/main/.github/workflows/test.yaml.
I have tested the following cases:
featureGates
section in yaml)Hope this is something you can consider adding in that action.
Thanks! 馃檹