Add yamlfmt setup action #191
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a new action called "setup-yamlfmt" that installs yamlffmt into the actions environment. Signed-off-by: Adolfo García Veytia (Puerco) <puerco@chainguard.dev>
|
Mmh I think the linter is wrong here? 🤔 |
luhring
reviewed
Jan 5, 2023
Comment on lines
+23
to
+36
| # - if version is "tip", install from tip of main. | ||
| # - if version is "latest", look up latest release. | ||
| # - otherwise, install the specified version. | ||
| case ${{ inputs.version }} in | ||
| tip) | ||
| echo "Installing yamlfmt using go install" | ||
| go install github.com/google/yamlfmt@main | ||
| ;; | ||
| latest) | ||
| tag=$(curl -L -s -u "username:${{ github.token }}" https://api.github.com/repos/google/yamlfmt/releases/latest | jq -r '.tag_name') | ||
| ;; | ||
| *) | ||
| tag="${{ inputs.version }}" | ||
| esac |
There was a problem hiding this comment.
I think the go install <repo>@<git-ref> syntax handles main and latest automatically, in addition to tagged versions. Would it make sense to let the go install command handle the version parsing here?
Yeah, I think you're right. It looks like it's treating this YAML file as a regular GitHub Actions workflow, not as an action. 🤔 |
lets ignore this one |
cpanato
requested changes
Feb 23, 2023
|
@puerco do still want this? |
|
@puerco gently ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a new action called "setup-yamlfmt" that installs yamlfmt into the actions environment.
Signed-off-by: Adolfo García Veytia (Puerco) puerco@chainguard.dev