Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some UI fine tuning for the dependency manager #2054

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

stonerl
Copy link
Collaborator

@stonerl stonerl commented Aug 3, 2023

The Package size is moved out of the button and shown next to the package in a bubble.

Install/Upgrade/Uninstall buttons now have the same width and are aligned with Show console.

@stonerl
Copy link
Collaborator Author

stonerl commented Aug 3, 2023

Here is a screenshot with the changes:

CleanShot 2023-08-03 at 18 22 27@2x

@stonerl
Copy link
Collaborator Author

stonerl commented Aug 3, 2023

Just to give you an explanation as to why I changed the design.

I think it is good UI practice to have vertically aligned buttons with the same size and not change its size. That is why I moved the download size out of the button.

Now it shows the number of total packages that are installed or the number of packages to be installed and the size of these packages. When a dependency has outdated packages, it shows the number of them and the size the update requires. After updating them, it then shows the total number of installed packages again.

But nothing is set in stone here @RunDevelopment already gave me valuable feedback on my first attempts.

@stonerl
Copy link
Collaborator Author

stonerl commented Aug 3, 2023

@RunDevelopment forgot about your remark regarding that the tags looking clickable. I could change the color, of course. So that it stand out from the button.

@stonerl
Copy link
Collaborator Author

stonerl commented Aug 3, 2023

For example:

CleanShot 2023-08-03 at 18 55 00@2x

The Package size is moved out of the button and
shown next to the package in a bubble.

Install/Upgrade/Uninstall buttons now have the
same width and are aligned with Show console.
@theflyingzamboni
Copy link
Collaborator

I actually find this confusing. Putting the size next to the package name implies that it's the size of the installed package rather than the download. When I first looked at this, I thought NCNN didn't have a listed size because it wasn't installed. It was only after looking at the buttons that I realized it was the opposite. I think keeping the size with the install/update buttons is more clear as to what the number represents.

@stonerl
Copy link
Collaborator Author

stonerl commented Aug 10, 2023

I actually need to wrap my head around this.

From my point of view this needs to be changed but I'm on board with your concerns. @theflyingzamboni

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants