Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cuda-mode should be derived from prog-mode #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

eyal0
Copy link

@eyal0 eyal0 commented Sep 5, 2021

This fixes #10

@eyal0
Copy link
Author

eyal0 commented Sep 5, 2021

To test this, I deleted the cached, compiled version of cuda-mode and patched the file. Here's what a cuda file with cuda-mode and spell-fu enabled used to look like:

image

Now I patch in the change into cuda-mode.el and delete cuda-mode.elc (not sure if that is needed)

emacs ~/.emacs.d/elpa/cuda-mode-20201013.2230/cuda-mode.el
# patch the file
rm ~/.emacs.d/elpa/cuda-mode-20201013.2230/cuda-mode.elc

Then I reopen my test file:

image

Notice that the word blarg is now a spelling error only in the comment. code is not spell checked by spell-fu, only comments are. This is correct behavior for spell-fu.

https://github.com/emacsmirror/spell-fu
@ideasman42

@eyal0
Copy link
Author

eyal0 commented Sep 5, 2021

This is what spell-fu is doing to ignore all but comments in prog-mode-derived modes:

https://github.com/emacsmirror/spell-fu/blob/master/spell-fu.el#L1062-L1068

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cuda-mode should be derived from prog-mode
1 participant