Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use duck typing and exceptions as well as spaces instead of tabs #40

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jihoon796
Copy link

Review on Reviewable

from urllib import urlencode
from urllib2 import Request, urlopen
import datetime
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i believe it should be alphabetical by module name.. so:

import datetime
from urllib import urlencode
from urllib2 import Request, urlopen

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, fixed now - thanks!

On Sun, Dec 27, 2015 at 11:23 PM, Corey Goldberg notifications@github.com
wrote:

In ystockquote.py
#40 (comment):

 from urllib import urlencode
  • from urllib2 import Request, urlopen
  • import datetime

i believe it should be alphabetical by module name.. so:

import datetime
from urllib import urlencode
from urllib2 import Request, urlopen


Reply to this email directly or view it on GitHub
https://github.com/cgoldberg/ystockquote/pull/40/files#r48462722.

from urllib import urlencode
from urllib2 import Request, urlopen

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup.. thanks for that.

@jihoon796
Copy link
Author

Hey Corey, please merge if everything looks good - otherwise, let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants