Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS load testing - chore(longpolling): set delay to one second #495

Merged
merged 4 commits into from
May 15, 2024
Merged

AWS load testing - chore(longpolling): set delay to one second #495

merged 4 commits into from
May 15, 2024

Conversation

shindigira
Copy link
Contributor

@shindigira shindigira commented May 13, 2024 •
edited

Changes

  • chore(longpolling): set delay to one second

@shindigira shindigira marked this pull request as draft May 13, 2024 18:05
@billhimmelsbach
Copy link
Contributor

billhimmelsbach commented May 14, 2024 •
edited

Great! Can we make a super short ticket that reminds us to reset this? You can mark it with a mvp tag so we don't forget.

@shindigira
Copy link
Contributor Author

Great! Can we make a super short ticket that reminds us to reset this? You can mark it with a mvp tag so we don't forget.

#497

@billhimmelsbach
Copy link
Contributor

If you bring this out of draft, I'll approve @shindigira!

@shindigira shindigira marked this pull request as ready for review May 15, 2024 16:06
@billhimmelsbach
Copy link
Contributor

Heyo, add a super small PR description would you @shindigira, for what goes in the git commit description?

billhimmelsbach
billhimmelsbach approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@billhimmelsbach billhimmelsbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@shindigira shindigira merged commit f781467 into main May 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billhimmelsbach billhimmelsbach billhimmelsbach approved these changes

@meissadia meissadia Awaiting requested review from meissadia meissadia is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shindigira @billhimmelsbach