Point of Contact - Phase 1 #453
Conversation
There was a problem hiding this comment.
Looks good! I had a few comments that you can scoop up for a second PR if you'd like.
Also, one more thing for the next PR would be to show a loading state before the API call completes, instead of showing a blank form that fills in with data. Slow internet connections would make this experience a little weird.
| }); | ||
| } | ||
|
|
||
| if (onSubmit) onSubmit(); | ||
| } catch (error) { | ||
| // eslint-disable-next-line no-console | ||
| console.log(error); |
There was a problem hiding this comment.
Some kind of error box for a later PR right?
There was a problem hiding this comment.
@billhimmelsbach Yes
It's Bill from the Future who just reviewed your next PR, which has those inputs disabled on load, which I think will definitely work for MVP. I do think natalia will have thoughts about the various load states later though, so can we make a post-mvp ticket to re-visit form loading states? |
|
|
Added todo items in POC - Phase 2 ticket
|
Closes #445 ## Changes - Consolidates Warnings phase 1 with Warnings skeleton ## How to test this PR Note: These steps demoed in the video below 1. Upload `sbl-validations-pass.csv` from the `regtech-data-validations` repo (or any file with warnings) 2. Navigate to the `Warnings` page 3. Observe that warnings were found and the alert is shown 4. Scroll to bottom of page and check the verification box 5. Click `Save and continue`, after a brief pause you should move to the POC page 6. Return to the `Warnings` page and observe that a `Success` alert is shown in place of the `warning` alert, indicating that the warnings are verified. 7. Scroll to bottom of page and observe that the checkbox is disabled, but checked 8. Observe that the `Save and continue` button is enabled, click it. 9. There should be no pause (no API call when Submission already verified), just a quick navigation to the next page. ## Screenshots https://github.com/cfpb/sbl-frontend/assets/2592907/28534b49-4cf4-4c14-888d-7d8bc0ee013a ## Note - Includes Point of Contact from #453 --------- Co-authored-by: shindigira <shindigira@gmail.com>
Closes #416
Changes
Screenshots
What we see:
Screen.Recording.2024-05-06.at.11.15.52.AM.mov