[Design Review] Upload #430

shindigira · 2024-04-29T23:33:51Z

closes #480
closes #473
closes #456
closes #467
closes #478

Note

yarn install to pull in the DSR changes to the pagination component
Screenshots show a checkmark instead of an exclamation mark during errors/warnings. This is changed

Changes

enhancement(Upload): Updated content to match the excel and figma
feat(Upload): initial load (get submission latest) 4xx/5xx's redirect to the 500 page
style(Upload Alerts - Links): underlined
style(Upload): Updated based on [Design Review] Upload #430 (comment)
~~enhancement(download report): removed caching headers -- using submissionId so the browser caching is fine~~

Extra note

The two scenarios not added to this design review:
- VALIDATION_EXPIRED (Needs a big file to test the two minute limit)
- If initial GET LATEST SUBMISSION fails, redirect to 500 page
The button changes are not in yet

Screenshots

Introduction

Never uploaded before

…`body`

…flatten the routing structure and hopefully simplify maintenance

… for reusability.

- Filing creation - Rename fetchFilingSubmissionLatest to fetchSubmissionLatest - Created useFilingAndSubmissionInfo

…ission process

…us upload

shindigira · 2024-05-15T16:52:38Z

@natalia-fitzgerald

Regarding the missing scenarios:
Thanks for adding to the list. Yes, those scenarios are not controllable from the frontend. However, the alerts for said scenarios are accounted for.

Regarding the secondary button pipe color:
This is pulled from the design system's button. To change this would require changing a nested DS/DSR item. We should ticket this item. #510

Regarding the secondary button height:
This one also requires a bit of an intricate DS/DSR style change as the buttons do not use a border by default. The change would be to all buttons to use a border with their respective matching color. We should ticket this item as well. #511

InstitutionHeading (2 spaces before/after pipe) and button content has been updated.

…nto errors-and-upload

…pload

…nto errors-and-upload

…pload

…w-upload

…into errors-and-upload

…nto errors-and-upload

…w-upload

billhimmelsbach

Great! Approving this for merging so that everything can land on our preview environment, but @natalia-fitzgerald will still get the final say on the design review. ✅

I've also added a ticket to cleanup some of our Typescript exceptions for post-mvp:
#528

billhimmelsbach · 2024-05-15T22:48:59Z

src/api/requests/fetchFilingSubmissionLatest.ts

-    'Validation STILL in-progress - Long Polling - RETRYING',
-    response,
-  );
+  if (import.meta.env.DEV) {


Wonder how the security scan stuff will handle these dev only console.logs. We'll find out. 👍

billhimmelsbach · 2024-05-15T22:54:36Z

src/components/Button.tsx

@@ -6,7 +6,7 @@ type ButtonProperties = ComponentProps<typeof ButtonDSR>;
 /* Handles new secondary styling */

 const newSecondaryStyle =
-  'cursor-pointer border-[1px] border-solid border-pacific bg-white text-pacific hover:border-[#0050B4] hover:bg-white hover:text-[#0050B4] focus:bg-transparent disabled:cursor-not-allowed disabled:border-none';
+  'cursor-pointer border-[1px] border-solid border-pacific bg-white text-pacific hover:border-[#0050B4] hover:bg-white hover:text-[#0050B4] focus:bg-white disabled:cursor-not-allowed disabled:border-none';


Looking forward to getting this in the DSR post-mvp.

billhimmelsbach · 2024-05-15T22:56:38Z

src/pages/Filing/FilingApp/FileDetailsValidation.tsx

+    dataGetSubmissionLatest.state === FileSubmissionState.SUBMISSION_ACCEPTED
+      ? 'Your file contains no errors and warnings have been verified'
+      : // @ts-expect-error key in
+        dataGetSubmissionLatest.state in fileSubmissionValidationStatus


Oh interesting... I added the exception to this ticket

meissadia added 30 commits April 3, 2024 12:01

fix: [axiosService] Add missing POST parameter

8688b34

[Filing Routing] Phase 1 - Mock Filing progress

6822d26

[Filing Routing] Phase 1 - Separate routes per step

9849158

fix: axiosService.request - remove unneeded data param in favor of …

fea91e3

…`body`

fix: useMemo to avoid duplicate placeholder objects being generated

46971d5

fix: FilingStepWrapper.helpers - remove unused eslint rule disables

2c2de5f

[Filing Routing] Phase 1 - Mock Filing progress

bc14e84

[Filing Routing] Phase 1 - Separate routes per step

2cbd121

fix: useMemo to avoid duplicate placeholder objects being generated

e7d28d1

fix: FilingStepWrapper.helpers - remove unused eslint rule disables

9c52113

Update imports after rebase

d912fc7

Update imports after rebase part 2

9257eb7

Add "tasks" to our mock filing

c60e6e6

Sync axiosService file

2867e7b

Filing step - Display "current" highlight even if step is incomplete

cd9a385

Filing - Placeholder for "is step complete?" status

b937bc4

Filing step - Improve spacing between step indicators

5b6c4f3

Filing steps - Remove custom hook that contained routes, which helps …

c0be487

…flatten the routing structure and hopefully simplify maintenance

Merge branch 'main' into 331-filing-routing_phase1-mock-data

f66f7b3

Filing steps - Revamp flex alignment of page elements

0c0d989

[ScreenReaderOnly] Component: Extract from Filing step indicator code…

cd69c7b

… for reusability.

Filing steps - More dynamic routes (year and lei from the url)

e64c41c

Filing steps - Add TODO to check on StepIndicator widths

a0dcab9

Merge branch 'main' into 331-filing-routing_phase1-mock-data

74506f3

fix: [axiosService] Always include "body" for post/put/patch requests

f8f1bdc

feat: [API]

502c82c

- Filing creation - Rename fetchFilingSubmissionLatest to fetchSubmissionLatest - Created useFilingAndSubmissionInfo

feat: [FilingOverview] Determine and link to next incomplete step

152ceb6

feat: [Filing] Display current Institution's progress within the subm…

4ebc759

…ission process

feat: [Filing] Placeholder pages for Filing steps

a0fa68b

fix: [Institution card] Routing logic for a Submissio n with a previo…

77c7ea0

…us upload

shindigira added 5 commits May 15, 2024 09:53

button content

56d6c67

Merge branch 'design-review-upload' of github.com:cfpb/sbl-frontend i…

ba66606

…nto errors-and-upload

Merge branch 'main' of github.com:cfpb/sbl-frontend into errors-and-u…

8f740e8

…pload

Merge branch 'main' into design-review-upload

3615120

Merge branch 'main' into resolve-errors-bugs-1

e600ff7

shindigira requested a review from meissadia May 15, 2024 17:01

shindigira added 4 commits May 15, 2024 10:08

style(InstitutionHeading): 2 spaces instead of 1

71214e1

Merge branch 'design-review-upload' of github.com:cfpb/sbl-frontend i…

3f6849b

…nto errors-and-upload

resolve merge conflict - one second longpolling

86880b0

Merge branch 'main' of github.com:cfpb/sbl-frontend into errors-and-u…

e2a465b

…pload

This was referenced May 15, 2024

[Button] Secondary - Pipe color #510

Open

[Button] Variants should have the same height #511

Open

shindigira added 12 commits May 15, 2024 11:04

merged with main

e32cb89

Merge branch 'main' of github.com:cfpb/sbl-frontend into design-revie…

5e90e17

…w-upload

Merge branch 'resolve-errors-bugs-1' of github.com:cfpb/sbl-frontend …

85b8db5

…into errors-and-upload

Merge branch 'design-review-upload' of github.com:cfpb/sbl-frontend i…

ebb9e1c

…nto errors-and-upload

updated with main

df816a9

updated with main

5b68cf3

Merge branch 'design-review-upload' of github.com:cfpb/sbl-frontend i…

3f3398e

…nto errors-and-upload

merged with all

c9c78a5

resolve merge conflict part 2

d36a57b

point of contact - double issue

137f402

upload button always primary

aa28d1d

resolve merge conflicts

d9abe04

shindigira changed the title ~~[Design Review] Upload~~ [Design Review] Upload, Errors & Warnings May 15, 2024

shindigira changed the title ~~[Design Review] Upload, Errors & Warnings~~ [Design Review] Upload May 15, 2024

Merge branch 'main' of github.com:cfpb/sbl-frontend into design-revie…

d757afc

…w-upload

billhimmelsbach approved these changes May 15, 2024

View reviewed changes

shindigira merged commit e723fc0 into main May 15, 2024
4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Design Review] Upload #430

[Design Review] Upload #430

shindigira commented Apr 29, 2024 •

edited

shindigira commented May 15, 2024 •

edited

billhimmelsbach left a comment

billhimmelsbach May 15, 2024

billhimmelsbach May 15, 2024

billhimmelsbach May 15, 2024

[Design Review] Upload #430

[Design Review] Upload #430

Conversation

shindigira commented Apr 29, 2024 • edited

Note

Changes

Extra note

Screenshots

Introduction

Never uploaded before

Pass

Warnings

Errors

SUBMISSION_ACCEPTED - no warnings

SUBMISSION_ACCEPTED - warnings

File size upload limit (Can use 2MB test limit -- normally 2GB)

Incorrect file type (renamed to `.csv) -- General Catch-All Validation Error

Incorrect file type (example .png)

Submission Malformed

shindigira commented May 15, 2024 • edited

billhimmelsbach left a comment

Choose a reason for hiding this comment

billhimmelsbach May 15, 2024

Choose a reason for hiding this comment

billhimmelsbach May 15, 2024

Choose a reason for hiding this comment

billhimmelsbach May 15, 2024

Choose a reason for hiding this comment

shindigira commented Apr 29, 2024 •

edited

Incorrect file type (example `.png`)

shindigira commented May 15, 2024 •

edited