Filing process routing - Phase 2 (Live data) #406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…flatten the routing structure and hopefully simplify maintenance
… for reusability.
- Filing creation - Rename fetchFilingSubmissionLatest to fetchSubmissionLatest - Created useFilingAndSubmissionInfo
…ettings to allow refetch on navigate
shindigira
reviewed
Apr 26, 2024
…ionLatest, adds TODOs
meissadia
commented
Apr 29, 2024
|
@shindigira @billhimmelsbach Issue with infinite This is ready for one last review. |
shindigira
previously requested changes
Apr 29, 2024
billhimmelsbach
approved these changes
Apr 30, 2024
There was a problem hiding this comment.
Looks good @meissadia! Thanks so much for your hard work on this one! 🥳
Chatted with @meissadia about consolidating the filing status definitions, which we can do in a later PR. 👍
@billhimmelsbach Added a ticket for this so I don't let it slip: #433 |
shindigira
added a commit
that referenced
this pull request
May 6, 2024
closes #333 closes #401 ## Note (05/02/24) The `sbl-filing` branch used is `main` -- latest working commit `0ddf51bd4bd0ab7aefac8cbb02c7797077885620` branched off [331-filing-routing_phase2-live-data](#406) ## Changes - feat(Resolve Errors): Single-Field Errors - feat(Resolve Errors): Multi-Field Errors - feat(Resolve Errors): Register-Level Errors - feat(Resolve Errors): Alerts present depending on errors or no errors - feat(Resolve Errors): Swappable between Step 1 (Syntax Errors) and Step 2 (Logical Errors/Register Errors); navigates to `warnings` on Step 2 (no errors) - enhancement(Upload): added an `enableLongPolling` boolean to `useGetSubmissionLatest`; default false - enhancement(Resolve Errors): Implemented 'react-markdown' -- Validation Description - chore(Resolve Errors): TypeScript handling in `FilingErrors.helpers.ts` - [chore(Upload): Hide FilingNavButtons if still loading](d380708) - feat(Resolve Errors): if a get submission latest fails, there is an Alert that pops up ## Next PRs - Pagination - Accessibility pass - Table styling size adjustments - Download linking the validation report ## How to Test 1. `yarn install` to install `react-markdown` 2. Select an institution and upload with the csv files provided (Syntax Errors and then Logical/Register Errors) 3. Ensure the right Alert occurs based on the error (or no errors) per segment 4. Verify all proper data is present per field-level section #### Test CSV's to use [all-errors-warnings-no-syntax-errors.csv](https://github.com/cfpb/sbl-frontend/files/15182232/all-errors-warnings-no-syntax-errors.csv) [sblar_syntax_errors_large.csv](https://github.com/cfpb/sbl-frontend/files/15182233/sblar_syntax_errors_large.csv) [sblar_syntax_errors.csv](https://github.com/cfpb/sbl-frontend/files/15182234/sblar_syntax_errors.csv) Note: If Syntax Errors are present, then validation for the logical errors/warnings do not occur. Hence, why the test CSV's has either syntax errors or logical errors; not both. ## Screenshots |Markdown| |--| |<img width="602" alt="Screenshot 2024-05-02 at 2 40 05 AM" src="https://github.com/cfpb/sbl-frontend/assets/13324863/c277389e-46c3-4374-8195-740e3b04b193">| | SingleFieldErrors | Success | Register-Level | |--|--|--| |<img width="411" alt="Screenshot 2024-05-01 at 4 44 52 PM" src="https://github.com/cfpb/sbl-frontend/assets/13324863/776da07d-7c9a-4dca-9fe9-24e106ac00e2">|<img width="400" alt="Screenshot 2024-05-01 at 4 45 10 PM" src="https://github.com/cfpb/sbl-frontend/assets/13324863/4682d70c-52dc-40fb-9f8b-a3e0c72d8247">|<img width="403" alt="Screenshot 2024-05-01 at 4 45 45 PM" src="https://github.com/cfpb/sbl-frontend/assets/13324863/c1b6e28e-c6e1-4b1a-902b-b7803aa91f77">| --------- Co-authored-by: Meis <meissadia@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #404
Changes
Filingwhen neededWarnings,Errorswould show complete)How to test this PR
Uploadpage (Save..button disabled)Errorspage (Save..button enabled). Also verify that the step indicator at the top of the page updates to reflect the status of upcoming steps.Screenshots (Updated 4/25)
filing-steps-4-25.mov