Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix][Filing landing] Associated institution links - Avoid "list" styles at mobile screen sizes #340

Merged
merged 17 commits into from Apr 29, 2024

Conversation

meissadia
Copy link
Collaborator

@meissadia meissadia commented Mar 29, 2024

Closes #339

Changes

  • remove the type='list' prop from the <Link>
  • Add class font-medium to match previously applied font weight

How to test this PR

  1. Visit http://localhost:8899/landing
  2. View associated institution section at mobile vs desktop width
  3. Verify links do not switch to full-width on mobile

Screenshots

Desktop styles remain unchanged.

Mobile styles - Before

Image

Mobile styles - After

Image

@shindigira
Copy link
Contributor

shindigira commented Mar 29, 2024

Basically giving a "design review".

This is MUCH better looking than using list links. Maybe slightly too squished together though.

@billhimmelsbach
Copy link
Contributor

This is better than what was there before @meissadia, but my fingers are too big to click on these heh 👉❌

Would you mind putting some space between those links on mobile @meissadia?

@meissadia
Copy link
Collaborator Author

@natalia-fitzgerald I know you were going to explore options for this, but I went ahead and added 15px spacing between Institution links as a starting point. 30px spacing felt a bit much.

View 15px 30px
Mobile Screenshot 2024-04-01 at 12 35 45 PM Screenshot 2024-04-01 at 12 49 10 PM
Desktop Screenshot 2024-04-01 at 12 36 00 PM Screenshot 2024-04-01 at 12 48 58 PM

@meissadia meissadia mentioned this pull request Apr 3, 2024
7 tasks
@meissadia
Copy link
Collaborator Author

@meissadia Be ware this component is used elsewhere, so any spacing/styling should be conditional or prop based.

@natalia-fitzgerald
Copy link

@meissadia
At desktop I prefer 10px. I am still looking at mobile.

@meissadia
Copy link
Collaborator Author

@natalia-fitzgerald Adjusted desktop links to be 10px apart.

Page Mobile Desktop
User profile Screenshot 2024-04-04 at 3 25 45 PM Screenshot 2024-04-04 at 3 25 52 PM
Auth. landing Screenshot 2024-04-04 at 3 26 00 PM Screenshot 2024-04-04 at 3 26 15 PM

@natalia-fitzgerald
Copy link

@meissadia - What width does the mobile column in your table represent? Is it a tablet width?

@meissadia
Copy link
Collaborator Author

@meissadia - What width does the mobile column in your table represent? Is it a tablet width?

@natalia-fitzgerald Looks like slightly larger than "tablet width (768px)". Instead around 817px wide in order to render the text on single lines.

@meissadia
Copy link
Collaborator Author

@natalia-fitzgerald Here are some updated screenshots, using the more standardized screen widths available in Chrome's dev tools.

Screen width Screenshot
Mobile - 425px mobile-425px
Tablet - 768px tablet-768px
Laptop - 1024px laptop-1024px

@billhimmelsbach
Copy link
Contributor

Heyo @natalia-fitzgerald, could you take another peek at this with the screenshot above?

@natalia-fitzgerald
Copy link

@meissadia
For mobile (425px), what would you think of breaking financial institution name to the next line at mobile so that it stays next to the LEI (and Approved is on the first line by itself)? Or do you think we would be short on space potentially?

@meissadia
Copy link
Collaborator Author

@natalia-fitzgerald I imagine it would depend on the length of an Institution's name. Longer Institution names could still cause LEI to wrap, resulting in 3 lines.

My vote is to leave it as-is for now.

Screenshot 2024-04-24 at 12 34 53 PM

@natalia-fitzgerald
Copy link

@meissadia
Yeah I had the same thought/suspicion so I'm with you on leaving this the way you have it.

@natalia-fitzgerald I imagine it would depend on the length of an Institution's name. Longer Institution names could still cause LEI to wrap, resulting in 3 lines.

My vote is to leave it as-is for now.

Screenshot 2024-04-24 at 12 34 53 PM

Copy link
Contributor

@billhimmelsbach billhimmelsbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@meissadia Yeah I had the same thought/suspicion so I'm with you on leaving this the way you have it.

If @natalia-fitzgerald is happy, I'm happy! 👍

@billhimmelsbach
Copy link
Contributor

@meissadia I think this one's good to go! 👍

@meissadia meissadia merged commit afffc7b into main Apr 29, 2024
2 checks passed
@meissadia meissadia deleted the 339-homepage-institution-links branch April 29, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Mobile][Filing landing] Institution link styles should not change
4 participants