New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix][Filing landing] Associated institution links - Avoid "list" styles at mobile screen sizes #340
Conversation
…les at mobile screen sizes
Basically giving a "design review". This is MUCH better looking than using list links. Maybe slightly too squished together though. |
This is better than what was there before @meissadia, but my fingers are too big to click on these heh 👉❌ Would you mind putting some space between those links on mobile @meissadia? |
…fpb/sbl-frontend into 339-homepage-institution-links
@natalia-fitzgerald I know you were going to explore options for this, but I went ahead and added 15px spacing between Institution links as a starting point. 30px spacing felt a bit much.
|
@meissadia Be ware this component is used elsewhere, so any spacing/styling should be conditional or prop based. |
@meissadia |
@natalia-fitzgerald Adjusted desktop links to be 10px apart.
|
@meissadia - What width does the mobile column in your table represent? Is it a tablet width? |
@natalia-fitzgerald Looks like slightly larger than "tablet width (768px)". Instead around 817px wide in order to render the text on single lines. |
@natalia-fitzgerald Here are some updated screenshots, using the more standardized screen widths available in Chrome's dev tools.
|
Heyo @natalia-fitzgerald, could you take another peek at this with the screenshot above? |
@meissadia |
@natalia-fitzgerald I imagine it would depend on the length of an Institution's name. Longer Institution names could still cause LEI to wrap, resulting in 3 lines. My vote is to leave it as-is for now. |
@meissadia
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@meissadia Yeah I had the same thought/suspicion so I'm with you on leaving this the way you have it.
If @natalia-fitzgerald is happy, I'm happy! 👍
@meissadia I think this one's good to go! 👍 |
Closes #339
Changes
type='list'
prop from the<Link>
font-medium
to match previously applied font weightHow to test this PR
Screenshots
Desktop styles remain unchanged.
Mobile styles - Before
Mobile styles - After