Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Review second) Update FI profile - phase3 (part II) #282

Merged
merged 34 commits into from
Mar 13, 2024
Merged

(Review second) Update FI profile - phase3 (part II) #282

merged 34 commits into from
Mar 13, 2024

Conversation

meissadia
Copy link
Collaborator

@meissadia meissadia commented Feb 28, 2024 •
edited

Part 2 of #222

Changes

  • Populates form's defaultValues with existing Institution data
  • Implements Clear form functionality
  • Removes previous method of providing form input defaults
  • Removes vague id=stuff
  • Temp fix for TextArea resizing issue

TODO

  • Lots of Typescript stuff (Will work to address these issues in my next PR)

How to test this PR

  1. In browser console, ensure routing is enabled (setIsRoutingEnabled(true))
  2. Login with a user who has an associated institution
  3. Click on the institution to View it's profile
  4. Click on Update your financial institution profile
  5. Modify a single field
  6. Hit the Clear form button, observe that the edited data is reset
  7. Modify a single field
  8. Hit Submit
  9. Verify you are redirected to the /summary route and shown a simulated "Success" confirmation
  10. In console, look for data to be submitted (before format) and confirm the field you edited reflects the data you entered

meissadia and others added 20 commits February 22, 2024 12:03
@meissadia
fix: [CrumbTrail] Allow conditional entries
48949ca
@meissadia
fix: [UpdateInstitutionProfile]
240aff4 
- [Add] Fetch Institution data
- [Add] Breadcrumb to return to View page
@meissadia
fix: [UpdateInstitutionProfile]
adf4a18 
- [Add] Review FI details
@meissadia
feat: [UpdateFinancialProfile] Display FinancialInstitutionDetails
d0a4a62
@meissadia
feat: [UpdateFinancialProfile] Display FinancialInstitutionDetails an…
661ae59 
…d include in submitted DTO
@meissadia
feat: [UpdateFinancialProfile] Display UpdateIdentifyingInformation a…
3b3233b 
…nd include in submitted DTO
@meissadia
feat: [InputEntry] Support display of (optional) label
1d4415f
@meissadia
fix: Lint error
c527d56
@meissadia
feat: [UpdateFinancialProfile] Display AffiliateInformation and inclu…
de66307 
…de in submitted DTO
@meissadia
feat: [LabelOptional] Extract to a reusable component
b926c51
@meissadia
feat: [UpdateFinancialProfile] Display AffiliateInformation and inclu…
190eb16 
…de in submitted DTO
@meissadia
fix: [UpdateAffiliateInformation] Display initial checkbox state and …
3373a31 
…"Other" details text
@meissadia
feat: [UpdateFinancialProfile] Simulated success upon form submission
6b5187e
@meissadia
Merge branch 'main' into 222-update-fi-profile-phase1
7544f44
@meissadia
Merge branch 'main' into 222-update-fi-profile-phase1
33c0a9b
@meissadia
fix: [UpdateAffiliateInformation] Extract UFPForm in prep for generat…
c20b8c6 
…ion of defaultValues
@meissadia
fix: [UpdateAffiliateInformation] Change filename case
eb770a8
@shindigira
fix: removed double reference
3236824
@meissadia @shindigira
Update src/components/LabelOptional.tsx
4753436 
Co-authored-by: S T <shindigira@gmail.com>
@meissadia
[UpdateInstitutionProfile]
6508285 
-  Improved population of existing form data
- Temp fix for TextArea resizing issue
- Implements `Clear form` functionality
This was referenced Feb 28, 2024
Closed
Merged
@meissadia meissadia changed the title Update FI profile - phase3 (part II) (Review second) Update FI profile - phase3 (part II) Feb 29, 2024
Base automatically changed from 222-update-fi-profile-phase1 to main March 6, 2024 18:24
@shindigira
feat: Zod Schema Update - Centralize form types, Regex checks to TIN,…
f5fb4d6 
… LEI (#290)

closes #273 

### Changes
- feat: Moved `ProfileForm` types to `types/formTypes`.
- feat: Addressed the extra _approval_ field on `Get Associated
Institution` request.
- feat: Adds the `getZodKeys` function to extract flattened fields from
Zod Schemas
- todo: Added TODO for handling the edge case of where fetched financial
institutions fail input validation -
#292

### Notes
@meissadia This should be used in Phase 4 of Update your Financial
Institution - Zod and TypeScript handling


### Reference
- getZodKeys: colinhacks/zod#2134
@meissadia @shindigira
Update src/pages/ProfileForm/Step1Form/Step1Form.tsx
f609163 
Co-authored-by: S T <shindigira@gmail.com>
shindigira
shindigira requested changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@shindigira shindigira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should updates types handling based on the backend schema.

src/pages/Filing/UpdateFinancialProfile/UpdateIdentifyingInformation.tsx Show resolved Hide resolved
@billhimmelsbach
Copy link
Contributor

@shindigira Can we get a re-review on this?

shindigira
shindigira approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@shindigira shindigira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working great. Many of the changes will be in your Phase 4 PR and thus ignored here.

@meissadia meissadia merged commit af57b08 into main Mar 13, 2024
2 checks passed
@meissadia meissadia deleted the 222-update-fi-profile-phase3-beta branch March 13, 2024 15:24
@meissadia meissadia linked an issue Mar 14, 2024 that may be closed by this pull request
[Page] Update your financial institution profile #222
Closed
25 tasks
@meissadia meissadia mentioned this pull request Mar 28, 2024
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shindigira shindigira shindigira approved these changes

@billhimmelsbach billhimmelsbach Awaiting requested review from billhimmelsbach billhimmelsbach is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Page] Update your financial institution profile
3 participants
@meissadia @billhimmelsbach @shindigira