Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

added /{lei}/filings/{period_code} endpoint and pytest #145

Conversation

nargis-sultani
Copy link
Contributor

@nargis-sultani nargis-sultani commented Apr 6, 2024

Additions

Removals

Changes

Testing

Screenshots

Notes

Todos

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows the standards laid out in the development playbook
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 馃憞)
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool 鉃★笍

Testing checklist

Browsers

  • Chrome
  • Firefox
  • Safari
  • Internet Explorer 8, 9, 10, and 11
  • Edge
  • iOS Safari
  • Chrome for Android

Accessibility

  • Keyboard friendly
  • Screen reader friendly

Other

  • Is useable without CSS
  • Is useable without JS
  • Flexible from small to large screens
  • No linting errors or warnings
  • JavaScript tests are passing

Copy link

github-actions bot commented Apr 6, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
聽聽src/sbl_filing_api/entities/repos
聽聽submission_repo.py
聽聽src/sbl_filing_api/routers
聽聽filing.py 55
Project Total

This report was generated by python-coverage-comment-action

Copy link
Contributor

@jcadam14 jcadam14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This story is actually meant for the backend to look into the access token, get all the LEIs from it, and then get the existing filings for that lei and period. Plus, this is a POST-MVP requirement because we still have to discuss the flow if a filing doesn't exist, what happens. So for now I think we need to reject this (we won't be using Tasks also, so the call to populate_missiing_tasks is not need for MVP), focus on finishing #141 because that's actually causing issues with the frontend flow if someone uploads a poorly formatted CSV

@nargis-sultani nargis-sultani deleted the features/142_return_all_filings_for_given_user_and_period branch April 8, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants