Task 42: structure validator CLI output

[nargis-sultani]

No description provided.

[nargis-sultani]

Fixing linter issues

[github-actions]

Coverage report

The coverage rate went from 81.08% to 78.4% ⬇️
The branch rate is 57%.

0% of new lines are covered.

Diff Coverage details (click to unfold)

src/validator/create_schemas.py

0% of new lines are covered (0% of the complete file).
Missing lines: 4, 5, 33, 45, 46, 47, 48, 49, 50, 51, 52, 53, 55, 57, 58, 60, 61, 64, 69, 71, 72, 75, 77, 79, 85, 89, 90, 91, 92, 93, 94, 96, 107, 109, 112, 113, 114, 115, 117, 118, 119, 121

src/validator/main.py

0% of new lines are covered (0% of the complete file).
Missing lines: 11, 30

[aharjati]

Is this ready for review?

just heads up: I see this error when running validator against the good and bad CSV files:

le "/workspaces/regtech-data-validator/src/validator/main.py", line 11, in <module>
    from create_schemas import validate_phases_by_lei
ImportError: cannot import name 'validate_phases_by_lei' from 'create_schemas' (/workspaces/regtech-data-validator/src/validator/create_schemas.py)
/workspaces/regtech-dat

Also, we should add unit tests for create_schemas. Create_schemas was being used for local testing so that's why we didn't have unit tests. Now, we are using it to generate JSON data that will be called by API so we should add unit tests for it. I created unit tests for create_schemas in my WIP branch: src/tests/test_schema_functions.py.
so maybe we can reuse some of the unit tests

[nargis-sultani]

Is this ready for review?

just heads up: I see this error when running validator against the good and bad CSV files:

le "/workspaces/regtech-data-validator/src/validator/main.py", line 11, in <module>
    from create_schemas import validate_phases_by_lei
ImportError: cannot import name 'validate_phases_by_lei' from 'create_schemas' (/workspaces/regtech-data-validator/src/validator/create_schemas.py)
/workspaces/regtech-dat

Also, we should add unit tests for create_schemas. Create_schemas was being used for local testing so that's why we didn't have unit tests. Now, we are using it to generate JSON data that will be called by API so we should add unit tests for it. I created unit tests for create_schemas in my WIP branch: src/tests/test_schema_functions.py. so maybe we can reuse some of the unit tests

I don't see that locally, working fine. But I can add the unit tests.

[aharjati]

this validate_phases_by_lei does not exist in create_schemas.
If you run /usr/local/bin/python /workspaces/regtech-data-validator/src/validator/main.py SBL_Validations_SampleData_GoodFile_03312 023.csv , you'll see this error ImportError: cannot import name 'validate_phases_by_lei' from 'create_schemas' (/workspaces/regtech-data-validator/src/validator/create_schemas.py)

[aharjati]

FYI: functions in #32 does not handle LEI so you'll need update them to handle LEI check

[aharjati]

FYI: functions in #32 does not handle LEI so you'll need update them to handle LEI check

[nargis-sultani]

closing it because it works on my local branch but not on this PR, will recreate