Changed to use pivot tables in the download formatter #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||
jcadam14
added a commit
that referenced
this pull request
May 3, 2024
Closes #166 Changed the df_to_download to use pivot tables to generate the csv. This greatly improves the processing time of this function to just a few seconds for very large files, and consistently stays there as size increases. Also used QUOTE_NONNUMERIC instead of specifically escaping just the description column.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #166
Changed the df_to_download to use pivot tables to generate the csv. This greatly improves the processing time of this function to just a few seconds for very large files, and consistently stays there as size increases.
Also used QUOTE_NONNUMERIC instead of specifically escaping just the description column.