Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] add api endpoints to support anonymous data check #32

Closed
wants to merge 5 commits into from
Closed

[WIP] add api endpoints to support anonymous data check #32

wants to merge 5 commits into from

Conversation

aharjati
Copy link
Contributor

@aharjati aharjati commented Aug 17, 2023 •
edited

  • add api interface to validator
  • changed to use two-phase validations
  • update naics and geoids:
    • moved global data to util folder so it can be shared with validator and api
    • update naics and geo-ids from global to local
    • read the files once at beginning and pass it to validator.

screenshots:
Screenshot 2023-08-14 at 3 55 24 PM
Screenshot 2023-08-14 at 3 54 13 PM
Screenshot 2023-08-14 at 12 03 51 PM
Screenshot 2023-08-11 at 11 41 27 AM

@aharjati aharjati linked an issue Aug 17, 2023 that may be closed by this pull request
[POST-MVP] Add API endpoint to validate one row #29
Open
@aharjati
Copy link
Contributor Author

putting this PR on-hold.

@aharjati aharjati changed the title add api endpoints to support anonymous data check [WIP] add api endpoints to support anonymous data check Aug 23, 2023
This was referenced Sep 15, 2023
Closed
Merged
@jcadam14
Copy link
Contributor

Is this valid anymore?

@jcadam14
Copy link
Contributor

jcadam14 commented Apr 2, 2024

We're closing this for now and will have a new PR once we revisit the need for this functionality.

@jcadam14 jcadam14 closed this Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hkeeler hkeeler Awaiting requested review from hkeeler

@guffee23 guffee23 Awaiting requested review from guffee23

@ethanbienstock ethanbienstock Awaiting requested review from ethanbienstock

@lchen-2101 lchen-2101 Awaiting requested review from lchen-2101

@nargis-sultani nargis-sultani Awaiting requested review from nargis-sultani

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[POST-MVP] Add API endpoint to validate one row
2 participants
@aharjati @jcadam14