Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [Icon] Restrict wrapper height to match icon height #312

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

meissadia
Copy link
Contributor

@meissadia meissadia commented Feb 20, 2024

Closes #303

This PR eliminates the extra height we were seeing from the .cf-icon-svg-wrapper elements...but it still doesn't seem to correct the odd alignment issues.

Other things I've tried:

  • Changing the .cf-icon-svg's vertical-align property. The only value that seems like it may be an improvement is vertical-align: sub, which shifts icons down 1 or 2 pixels.

Changes

How to test this PR

Screenshots

Notes

Copy link

netlify bot commented Feb 20, 2024

Deploy Preview for cfpb-design-system-react ready!

Name Link
🔨 Latest commit 620d620
🔍 Latest deploy log https://app.netlify.com/sites/cfpb-design-system-react/deploys/65d526d79b98250008e6973c
😎 Deploy Preview https://deploy-preview-312--cfpb-design-system-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Investigation] Difference in line-height between DS and DSR
1 participant