Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip fix: [AlertFieldLevel] margin 0.5em, icon vertical centering issue, TextInput changes, Checkbox changes #278

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

shindigira
Copy link
Contributor

@shindigira shindigira commented Jan 11, 2024

closes #276

POSTPONED

Will require a preceding DS approval before a DSR approval.

TODO

  • Change Margin between icon and text to 5px in AlertFieldLevel
  • fix the vertically align icon in Alert (not fieldlevel) (Delay LOW PRIORITY: [context](figma comment that we will revisit this change later))
  • vertically align Checkbox and label text, margin with text also
  • Error dotted line around checkbox/textinput
  • textinput/checkbox: red outline, get rid of hover blue, focus color should be same as border (e.g. error red)
    Dark hover colors: Text Input - Hover - Define state styling (Success/Warning/Error status) design-system#1881 (comment)

Changes

  • Sets text to inline instead of block
  • Vertically aligns the icon with the text
  • Sets the margin between the icon and the text to be 8px (0.5em)

Screenshots

Before After
Screenshot 2024-01-11 at 5 50 26 AM Screenshot 2024-01-11 at 5 50 35 AM

Copy link

netlify bot commented Jan 11, 2024

Deploy Preview for cfpb-design-system-react ready!

Name Link
🔨 Latest commit 314464f
🔍 Latest deploy log https://app.netlify.com/sites/cfpb-design-system-react/deploys/659fcc0347027100080d0c28
😎 Deploy Preview https://deploy-preview-278--cfpb-design-system-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shindigira shindigira changed the title fix: [AlertFieldLevel] margin 0.5em, icon vertical centering issue fix: [AlertFieldLevel] margin 0.5em, icon vertical centering issue, TextInput changes, Checkbox changes Jan 11, 2024
@shindigira shindigira changed the title fix: [AlertFieldLevel] margin 0.5em, icon vertical centering issue, TextInput changes, Checkbox changes wip fix: [AlertFieldLevel] margin 0.5em, icon vertical centering issue, TextInput changes, Checkbox changes Jan 11, 2024
@billhimmelsbach
Copy link
Contributor

Heyo @shindigira! Is this one ready for a review or is still WIP?

Copy link
Contributor

@billhimmelsbach billhimmelsbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heyo @shindigira! I know you're still working on this, but just wanted to let you know that after today's discussions, these three TODOs are going to be fixed at the source in the DS first instead of in the DSR in this PR:

  • Change Margin between icon and text to 5px in AlertFieldLevel
  • fix the centering icon in Alert (not fieldlevel) (Delay LOW PRIORITY: [context](figma comment that we will revisit this change later))
  • Error dotted line around checkbox/textinput

The first two of those TODOs (the margin and centering the icon) will also be de-prioritized and moved to the backlog for now too. Should make this PR a little smaller! 🤞

@shindigira shindigira marked this pull request as draft April 2, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AlertFieldLevel] Vertically centering text, 5px margin between icon and text
2 participants