TCCP: Cleanup detail page fee logic #8417
Conversation
There was a problem hiding this comment.
Looks great, even if I'm a little sad we have to remove some of the details because the data isn't structured enough. All the cards I spot checked were showing up as I'd expect. I left one suggestion that might just be me misunderstanding the data, so feel free to ignore that one.
cfgov/tccp/jinja2/tccp/card.html
Outdated
| @@ -419,30 +400,12 @@ <h2> | |||
| </div> | |||
| {% endif %} | |||
| {% if card.monthly_fee %} | |||
| {% if card.annual_fee %} | |||
| {% if card.annual_fee or not card.periodic_fee_type %} | |||
There was a problem hiding this comment.
I've already forgotten the intricacies of how the periodic fee data is structured, but I think we can get rid of the or not card.periodic_fee_type here and everywhere below. I put it in line 394 because we use the same space we show an annual fee for cards with no periodic fee (we just show it as "$0 annual fee"). But I think not card.periodic_fee_type will never be true here since it's nested under an if card.monthly_fee, which means card.periodic_fee_type should contain at least one item, "Monthly" (in theory, anyway—who knows if there are data errors that prove that assumption wrong).
If I'm misunderstanding that or there's some weird data thing going on that makes the or not card.periodic_fee_type necessary, ignore all that!
This commit simplifies some of the logic on the TCCP card detail page, removing code that tried to determine if a card has a varying periodic fee. The dataset schema doesn't provide enough information for us to reliably report this to users. This change simplifies the fee rendering so that we only show annual, monthly, and weekly fees, without information on periodic changes. See internal https://github.local/Design-Development/Design-Thinking-and-User-Research/issues/306#issuecomment-354469 for additional context behind this change. To test, run a local server with the latest data and visit a card page with fees, for example http://localhost:8000/consumer-tools/credit-cards/explore-cards/cards/credit-one-bank-national-association-platinum-visa-for-rebuilding-credit/
chosak
force-pushed
the
tccp/detail-fees-cleanup
branch
from
7403490
to
0ef644b
Compare
This PR simplifies some of the logic on the TCCP card detail page, removing code that tried to determine if a card has a varying periodic fee. The dataset schema doesn't provide enough information for us to reliably report this to users.
This change simplifies the fee rendering so that we only show annual, monthly, and weekly fees, without information on periodic changes.
See internal https://github.local/Design-Development/Design-Thinking-and-User-Research/issues/306#issuecomment-354469 for additional context behind this change.
How to test this PR
To test, run a local server with the latest data and visit a card page with fees, for example
http://localhost:8000/consumer-tools/credit-cards/explore-cards/cards/credit-one-bank-national-association-platinum-visa-for-rebuilding-credit/.
Checklist