Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace jQuery in "Before You Claim" #8321

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Replace jQuery in "Before You Claim" #8321

wants to merge 1 commit into from

Conversation

mistergone
Copy link
Member

@mistergone mistergone commented Apr 15, 2024

This PR replaces jquery functions and methods with "vanilla" JavaScript so we no longer rely on jQuery in this app.

I attempted to replace jQuery without changing any lines of the existing code, but I did have to change the reference to a few event handlers just for ease. The existing functional tests are passing.

Additions

  • Add dollar-sign.js which replaces relevant jQuery methods.

Changes

  • Change a few event handlers to use Query.on()

How to test this PR

  1. Check the functional tests in cypress
  2. Visually check the app to make sure it matches the production apa

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code follows the standards laid out in the CFPB development guidelines
  • Future todos are captured in comments and/or tickets
  • Project documentation has been updated, potentially one or more of:

Front-end testing

This app should function exactly as it did before.

- Add dollar-sign.js
- Change some event handlers in retirement code
@anselmbradford
Copy link
Member

Whoops, gave some suggestions and then realized I mis-read the jquery code for https://api.jquery.com/on/ and had the selector and data arguments swapped in my head. Deleted suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants