New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DATAP-1208 Convert reducers to RTK slices #482
Draft
wwhorton
wants to merge
95
commits into
main
Choose a base branch
from
WW-DATAP-1208-reducers-use-slices
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m/cfpb/ccdb5-ui into WW-DATAP-1208-reducers-use-slices
…-1208-reducers-use-slices
fix bug, shoudl be actions refactoring a lot of stuff adding new dependencies updates, and breaking a lot of tests save off some work save some work fixed routes.js logic so it fires correctly on page load renaming files to correct slice convention renaming lintin broken references make dates strings, fixing data lens action rename query action save off some more work update tests updating more unit tests, fixing missing logic save off more work fixing broken map trends chart, updating references, fixing modal hide button in print mode save work fixing references fixing more unit tests filterSlice tests cleanup fix zip typeahead querystring save off work, fixing queryslice tests fixing data export unit tests, adding filters to query string export fixing trendsslicetest format date fix, update configurestore adding proxy middleware make app.js like complaint explorer, migrating over to new react18 strict mode, fixing bug with tour asking to exit onExit handler update app spec with realstore clean up tests, fixing percapita trends work action bar test update convert has narrative to s functional Save work trend depth toggle to functional save work update trend depth toggle update tests for company receivd filter save off product / agg branch work
flacoman91
force-pushed
the
WW-DATAP-1208-reducers-use-slices
branch
from
April 10, 2024 17:11
94edfff
to
4429c20
Compare
flacoman91
changed the title
Ww datap 1208 reducers use slices
DATAP-1208 Convert reducers to RTK slices
Apr 12, 2024
…-1208-reducers-use-slices # Conflicts: # package.json # src/components/Filters/Company.js # src/components/Filters/Company.spec.js # src/components/Filters/FilterPanel.js # src/components/Filters/HasNarrative.js # src/components/Filters/HasNarrative.spec.js # src/components/Filters/__tests__/__snapshots__/CompanyReceivedFilter.spec.js.snap # src/components/Search/SearchComponents.js # src/components/Search/SearchPanel.js # src/components/Trends/TrendsPanel.less # src/components/__tests__/FilterPanel.spec.js # src/components/__tests__/Warning.spec.js # src/reducers/query/selectors.js # src/reducers/trends/selectors.js
# Conflicts: # src/actions/url.js # src/components/Filters/FilterPanel.js # src/components/Filters/Product.js # src/components/Filters/__tests__/Product.spec.js # src/reducers/query/query.js # src/reducers/query/selectors.js
flacoman91
reviewed
Apr 17, 2024
|
||
/** | ||
* Helper function generate and sort options | ||
* | ||
* @param {Array} aggsProducts - Products array from aggs reducer | ||
* @param {Array} queryProduct - Products array from query reducer. TBD this will move to new filters reducer in the future | ||
* @param {Array} filtersProducts - Products array from query reducer. TBD this will move to new filters reducer in the future |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note to self, fix this comment.
# Conflicts: # src/App.spec.js # src/components/Filters/__tests__/__snapshots__/CompanyReceivedFilter.spec.js.snap # src/components/Search/PillPanel.js # src/components/Search/SearchComponents.js # src/components/Trends/ExternalTooltip.js # src/components/Trends/FocusHeader.js # src/components/Trends/LensTabs.js # src/components/Trends/TrendDepthToggle.js # src/components/__tests__/FocusHeader.spec.js # src/components/__tests__/LensTabs.spec.js # src/components/__tests__/Warning.spec.js # src/components/__tests__/__snapshots__/TrendDepthToggle.spec.js.snap
# Conflicts: # src/actions/filter.js # src/actions/view.js # src/components/Filters/FilterPanel.js # src/components/Filters/FilterPanel.spec.js # src/components/Filters/FilterPanelToggle.js # src/components/List/ListPanel/ListPanel.js # src/components/Map/MapPanel.js # src/components/Trends/ExternalTooltip/ExternalTooltip.js # src/components/Trends/ExternalTooltip/ExternalTooltip.spec.js # src/components/Trends/ExternalTooltip/TooltipRow.js # src/components/Trends/TrendsPanel.js # src/components/Warnings/Warning.spec.js # src/reducers/trends/selectors.js
# Conflicts: # src/actions/filter.js # src/actions/view.js # src/components/Filters/FilterPanel.js # src/components/Filters/FilterPanel.spec.js # src/components/Filters/FilterPanelToggle.js # src/components/List/ListPanel/ListPanel.js # src/components/Map/MapPanel.js # src/components/Trends/ExternalTooltip/ExternalTooltip.js # src/components/Trends/ExternalTooltip/ExternalTooltip.spec.js # src/components/Trends/ExternalTooltip/TooltipRow.js # src/components/Trends/TrendsPanel.js # src/components/Warnings/Warning.spec.js # src/reducers/trends/selectors.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redux Toolkit divides redux state into "slices", which make managing state easier and more efficient. Explorer was converted to use slices, but CCDB hadn't yet. This is a PR converting all the reducers to slices, updating tests to accommodate the changes, and refactoring code where necessary, mainly in dispatches. Most of the content of the actions directory was removed since it's handled in the extraReducers piece of the slices, but where it seemed to make more sense to leave them as is, I did.
Removals
Changes
Testing
yarn test
: All tests should passNotes
Todos
Checklist