Feature/mapping get only lists #117
Conversation
|
I noticed after upgrading the test project to netcoreapp3.1 this one test fails without any other changes to the code, and it seems a bit flaky sometimes the enum is wrong but other times not. |
|
I have made a separate pull request to update netcoreapp3.1 first, this will fix the failing unit test |
|
@cezarypiatek I will update this pr soon with the latest changes of the upstream branch and use dotnet 3.0. Could you let me know if this is the right direction for this solution? |
|
@Wazowsk1 please rebase your branch to master and push it again. Then I will be able to review your changes. |
jorisdebock
force-pushed
the
feature/mapping-get-only-lists
branch
from
f36acb3
to
2f6fae0
Compare
|
@Wazowsk1 I've started do review your code. Hell lot of the work 👍 Please give me a couple of days for this. |
...pingGenerator/Mappings/MappingImplementors/SingleParameterForeachMappingMethodImplementor.cs
Outdated
Show resolved
Hide resolved
| return true; | ||
| } | ||
|
|
||
| if (ContainsCollectionWithoutSetter(MappingHelper.GetElementType(member.Type))) |
There was a problem hiding this comment.
Needs to handle recursive types to avoid stack overflow exception
There was a problem hiding this comment.
I have added the mappingPath check in the implementor
| { | ||
| foreach (var member in type.GetMembers().Where(ObjectHelper.IsPublicPropertySymbol).OfType<IPropertySymbol>()) | ||
| { | ||
| if (ObjectHelper.IsSimpleType(member.Type) || !MappingHelper.IsCollection(member.Type)) |
There was a problem hiding this comment.
I think this condition will prevent inspections of complex objects
jorisdebock
force-pushed
the
feature/mapping-get-only-lists
branch
from
0e0f951
to
621642d
Compare
#112