Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vue-loader and template support #61

Merged
merged 6 commits into from
May 19, 2024

Conversation

OSpoon
Copy link
Collaborator

@OSpoon OSpoon commented May 15, 2024

I added the necessary modules vue-loader, ts-loader, and @vue/compiler-sfc in programs/develop. Additionally, I have added vue and vue-typescript templates.

Now, using the vue and vue-typescript templates, we can achieve the same presentation effect as with the react and react-typescript templates.

When you have time, please give me some suggestions. I would be very happy.

@cezaraugusto cezaraugusto self-requested a review May 15, 2024 19:04
Copy link
Owner

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @OSpoon, this is a huge progress towards Vue support, thanks a lot! I got able to create and start the project using both templates! 🧩

There are a few changes I left in the comments. I also need you to please update the dev-server in this line to set watchFiles to undefined not only for React but also Vue extensions. This way we can get true hot-module replacement for .vue files.

Hot-module replacement isn't working for content_scripts, unfortunately (using vue-typescript template). It is not a blocker to land these changes and have at least partial support for Vue, but if you any existing config that managed to do this, I'd love to know and find ways to add it to a future patch.

programs/develop/webpack/loaders/vueLoaders.ts Outdated Show resolved Hide resolved
programs/develop/webpack/webpack-config.ts Outdated Show resolved Hide resolved
programs/develop/webpack/loaders/vueLoaders.ts Outdated Show resolved Hide resolved
programs/develop/webpack/loaders/vueLoaders.ts Outdated Show resolved Hide resolved
programs/develop/webpack/loaders/vueLoaders.ts Outdated Show resolved Hide resolved
programs/develop/webpack/loaders/vueLoaders.ts Outdated Show resolved Hide resolved
Copy link
Owner

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ++

Thanks a lot for your contribution, @OSpoon! Will ensure this is added in the next release.

@cezaraugusto cezaraugusto merged commit 46cc810 into cezaraugusto:main May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants