-
-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vue-loader and template support #61
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @OSpoon, this is a huge progress towards Vue support, thanks a lot! I got able to create and start the project using both templates! 🧩
There are a few changes I left in the comments. I also need you to please update the dev-server in this line to set watchFiles to undefined
not only for React but also Vue extensions. This way we can get true hot-module replacement for .vue
files.
Hot-module replacement isn't working for content_scripts
, unfortunately (using vue-typescript
template). It is not a blocker to land these changes and have at least partial support for Vue, but if you any existing config that managed to do this, I'd love to know and find ways to add it to a future patch.
programs/create/templates/vue-typescript/template/content/content/ContentApp.vue
Outdated
Show resolved
Hide resolved
programs/create/templates/vue-typescript/template/content/ContentApp.vue
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ++
Thanks a lot for your contribution, @OSpoon! Will ensure this is added in the next release.
I added the necessary modules
vue-loader
,ts-loader
, and@vue/compiler-sfc
inprograms/develop
. Additionally, I have added vue and vue-typescript templates.Now, using the vue and vue-typescript templates, we can achieve the same presentation effect as with the react and react-typescript templates.
When you have time, please give me some suggestions. I would be very happy.