Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOCS: Updated docker instructions, removed obsolete variables #2217

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

DOCS: Updated docker instructions, removed obsolete variables #2217

wants to merge 1 commit into from

Conversation

waldbauer-certat
Copy link
Contributor

Fixes #2195

@waldbauer-certat
DOCS: Updated docker instructions, removed obsolete variables
bdb8cf9 
Fixes #2195

Signed-off-by: Sebastian Waldbauer <waldbauer@cert.at>
sebix
sebix requested changes Jul 15, 2022
View reviewed changes
docs/user/installation.rst
-e INTELMQ_SOURCE_PIPELINE_HOST: redis \
-e INTELMQ_DESTINATION_PIPELINE_HOST: redis \
-e INTELMQ_REDIS_CACHE_HOST: redis \
sudo docker run -e INTELMQ_PIPELINE_HOST: redis \
Copy link
Member

@sebix sebix Jul 15, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The environment variable INTELMQ_PIPELINE_HOST is only used in the tests, but not in the normal pipeline/bot code. Should be INTELMQ_SOURCE_PIPELINE_HOST and INTELMQ_DESTINATION_PIPELINE host IMO.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To clarify what I meant: Setting INTELMQ_PIPELINE_HOST does not set the pipeline host to redis for the bots at runtime and is thus ineffective.

@sebix sebix added bug Indicates an unexpected problem or unintended behavior documentation Indicates a need for improvements or additions to documentation labels Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebix sebix sebix requested changes

Assignees
No one assigned
Labels
bug Indicates an unexpected problem or unintended behavior documentation Indicates a need for improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Installation documentation: obsolete docker environment variables?
2 participants
@waldbauer-certat @sebix