Remove approver-policy versions from install instructions #1448
Conversation
jetstack-bot
added
dco-signoff: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for cert-manager-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
cert-manager-prow
bot
added
the
needs-rebase
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
inteon
force-pushed
the
approver_policy_remove_versions
branch
from
19b2541
to
ef7f20c
Compare
cert-manager-prow
bot
removed
the
needs-rebase
There was a problem hiding this comment.
Thanks @inteon
I think this is better, because
- it makes the installation more readable and
- it reduces the steps needed to release a new trust-manager
- the hard coded version of trust-manager won't necessarily be appropriate when viewed in the versioned documentation URLs such as https://cert-manager.io/v1.12-docs.
In a future PR we could also change the previous helm upgrade cert-manager step to helm install cert-manager,
because I think a user might accidentally upgrade an important cert-manager installation if they're using the wrong kube context.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wallrj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cert-manager-prow
bot
added
lgtm
@wallrj requested these versions to be removed, see #1439 (review).