Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect logger initialisation #128

Open
SgtCoDFish opened this issue Apr 29, 2024 · 0 comments
Open

Incorrect logger initialisation #128

SgtCoDFish opened this issue Apr 29, 2024 · 0 comments

Comments

@SgtCoDFish
Copy link
Member

Loggers for the driver and the approver are currently ultimately created by klog.TODO in this section of code.

The flow control here is confusing and could be improved, and TODO is also documented as a "last resort".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SgtCoDFish