Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added class in ingressClassName as default if not specified #6908

Conversation

anirudhAgniRedhat
Copy link

The alert IngressWithoutClassName was introduced to Cluster. whether Ingress objects would exist without an ingressClassName specified. Given that without an ingressClassName specified, it's not clear what the ingress object is supposed to do, it's vital that alerting is taking place and actions are taken to set the ingressClassName properly for each ingress object.

And as the Ingress resources without a spec.ingressClassName are generated by the Cert-Manager.

Pull Request Motivation

We can create an Ingress without having IngressClassName specified. I am getting alerts messages that ingress Exists without IngressClassName Specified.

I propose that we can add default ingressClassName to issuer if ingressClassName is not specified.

Expected behaviour:
It should Set default ingressClassName if className is not specified.

Kind

bug : #6897

Release Note

NONE

Signed-off-by: anirudhAgniRedhat <aagnihot@redhat.com>
@cert-manager-prow cert-manager-prow bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 16, 2024
@cert-manager-prow
Copy link
Contributor

Hi @anirudhAgniRedhat. Thanks for your PR.

I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cert-manager-prow cert-manager-prow bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/acme Indicates a PR directly modifies the ACME Issuer code labels Apr 16, 2024
@cert-manager-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign sgtcodfish for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added the area/acme/http01 Indicates a PR modifies ACME HTTP01 provider code label Apr 16, 2024
@inteon
Copy link
Member

inteon commented Apr 17, 2024

/ok-to-test

@cert-manager-prow cert-manager-prow bot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 17, 2024
@maelvls maelvls self-assigned this Apr 22, 2024
@maelvls
Copy link
Member

maelvls commented Apr 22, 2024

Hey, thanks for opening a PR! I'll share my thoughts on #6897, and I'll come back here once we agree on the issue.

@inteon
Copy link
Member

inteon commented Apr 23, 2024

/test pull-cert-manager-master-make-verify

@anirudhAgniRedhat anirudhAgniRedhat closed this by deleting the head repository May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/acme/http01 Indicates a PR modifies ACME HTTP01 provider code area/acme Indicates a PR directly modifies the ACME Issuer code dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. ok-to-test release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants