feat: Adding API defaults unit test + testfile fixture

[jsnctl]

Pull Request Motivation

• Addresses Add tests for our API defaults #6817
• Adds a basic means to tag (via make update-apidefaults-*) defaults
• Adds unit test for defaults in /internal

e.g.

cert-manager/internal/apis/config/cainjector/v1alpha1/defaults.go

Line 31 in 620d6ff

defaultLeaderElectionNamespace = "kube-system"

updated to defaultLeaderElectionNamespace = "kube-system-abc" results in a test failure.

WIP as I wanted to sanity check this was the intention of the ticket & a reasonable pattern to follow before implementing for wider API space, but I'm also not very familiar with defaulter-autogen or the cert-manager project structure (w.r.t internal vs pkg)

Kind

feature/chore

Release Note

NONE

[jetstack-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign inteon for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jetstack-bot]

Hi @jsnctl. Thanks for your PR.

I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[inteon]

/ok-to-test

[jetstack-bot]

@jsnctl: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-cert-manager-master-make-test	f447eb1	link	true	/test pull-cert-manager-master-make-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[Osamaabdalsabour]

/address/

[jsnctl]

Recent merge from master appears to have resolved some of the CI failures from last week.

@inteon if you're happy with the pattern employed here after your review, I can go ahead and implement in other parts of the API where you think it'd be appropriate?

[inteon]

Pattern looks great, feel free to do the same thing for the other APIs!

[jsnctl]

@inteon This has now been applied to each of the APIs in internal/apis/config. Have a look across the wider codebase, I think these are the only defaults that're clearly testable in this format—are there any other cases we want to add here?

[inteon]

Thanks @jsnctl for fixing this issue, it should prevent us from unintentionally changing the default values in the future.
I added some code cleanup and formatted the json files so they are more readable.
This PR looks good to me. Please let me know if there is still something you would like to change.

This PR also shows that this area still needs a bit of work (eg. leaseDuration etc. should just be formatted as 1m instead of 60000000000). But those improvements are for another PR.

/lgtm
/approve
/hold In case you want to still change something.

[cert-manager-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [inteon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jsnctl]

Thanks @inteon, no further changes from me so if you're happy, merge away!

[inteon]

/unhold