New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use release namespace for leader election #6766
base: master
Are you sure you want to change the base?
use release namespace for leader election #6766
Conversation
Hi @aburan28. Thanks for your PR. I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
0f4cb25
to
623d905
Compare
Signed-off-by: Adam Buran <aburan28@gmail.com>
Signed-off-by: Adam Buran <aburan28@gmail.com>
623d905
to
fcebb10
Compare
Signed-off-by: Adam Buran <aburan28@gmail.com>
Signed-off-by: Adam Buran <aburan28@gmail.com>
Change the way that the leader election namespace is set. Currently the
values.yaml
file has an option to set the leader election namespace to.Values.leaderElection.namespace
but when developers install cert-manager into a different namespace the roles will not have permission to acquire leases in that namespace. This PR simplifies the Roles to use the cert-manager.namespace function which uses .Release.Namespace.Pull Request Motivation
Attempts to solve the following issue #6716
Kind
Release Note