Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First draft of e2e test to try to reproduce same domain multiple orders race condition #6516

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

First draft of e2e test to try to reproduce same domain multiple orders race condition #6516

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
539b60b
First draft of e2e test for double ingress
Git-Jiro Nov 19, 2023
174896f
change path in second ingress
Git-Jiro Nov 19, 2023
5e9e4c4
Add context
Git-Jiro May 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
59 changes: 59 additions & 0 deletions test/e2e/suite/issuers/acme/certificate/http01.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,9 @@ var _ = framework.CertManagerDescribe("ACME Certificate (HTTP01)", func() {
issuerName := "test-acme-issuer"
certificateName := "test-acme-certificate"
certificateSecretName := "test-acme-certificate"
certificateSecondSecretName := "test-acme-certificate-secondary"
ingressName := "test-acme-ingress"
ingressName2 := "test-acme-ingress-secondary"
// fixedIngressName is the name of an ingress resource that is configured
// with a challenge solve.
// To utilise this solver, add the 'testing.cert-manager.io/fixed-ingress: "true"' label.
Expand Down Expand Up @@ -271,6 +274,62 @@ var _ = framework.CertManagerDescribe("ACME Certificate (HTTP01)", func() {
Expect(err).NotTo(HaveOccurred())
})

It("should obtain two separate signed certificates with the same CN rom the ACME server when creating two annotated ingress resources", func() {

switch {
case util.HasIngresses(f.KubeClientSet.Discovery(), networkingv1.SchemeGroupVersion.String()):
ingClient := f.KubeClientSet.NetworkingV1().Ingresses(f.Namespace.Name)
By("Creating two Ingresses with the issuer name annotation set")
_, err := ingClient.Create(context.TODO(), util.NewIngress(ingressName, certificateSecretName, map[string]string{
"cert-manager.io/issuer": issuerName,
}, acmeIngressDomain), metav1.CreateOptions{})
Expect(err).NotTo(HaveOccurred())

ingress2 := util.NewIngress(ingressName2, certificateSecondSecretName, map[string]string{
"cert-manager.io/issuer": issuerName}, acmeIngressDomain)
ingress2.Spec.Rules[0].IngressRuleValue.HTTP.Paths[0].Path = "/different"

_, err = ingClient.Create(context.TODO(), ingress2, metav1.CreateOptions{})
Expect(err).NotTo(HaveOccurred())
case util.HasIngresses(f.KubeClientSet.Discovery(), networkingv1beta1.SchemeGroupVersion.String()):
ingClient := f.KubeClientSet.NetworkingV1beta1().Ingresses(f.Namespace.Name)
By("Creating two Ingresses with the issuer name annotation set")
_, err := ingClient.Create(context.TODO(), util.NewV1Beta1Ingress(ingressName, certificateSecretName, map[string]string{
"cert-manager.io/issuer": issuerName,
}, acmeIngressDomain), metav1.CreateOptions{})
Expect(err).NotTo(HaveOccurred())
_, err = ingClient.Create(context.TODO(), util.NewV1Beta1Ingress(ingressName2, certificateSecondSecretName, map[string]string{
"cert-manager.io/issuer": issuerName,
}, acmeIngressDomain), metav1.CreateOptions{})
Expect(err).NotTo(HaveOccurred())
default:
Fail("Neither " + networkingv1.SchemeGroupVersion.String() + " nor " + networkingv1beta1.SchemeGroupVersion.String() + " were discovered in the API server")
}

By("Waiting for first Certificate to exist")
cert, err := f.Helper().WaitForCertificateToExist(ctx, f.Namespace.Name, certificateName, time.Second*60)
Expect(err).NotTo(HaveOccurred())

By("Waiting for seond Certificate to exist")
cert2, err := f.Helper().WaitForCertificateToExist(ctx, f.Namespace.Name, certificateSecondSecretName, time.Second*60)
Expect(err).NotTo(HaveOccurred())

By("Waiting for the Certificate to be issued...")
cert, err = f.Helper().WaitForCertificateReadyAndDoneIssuing(ctx, cert, time.Minute*5)
Expect(err).NotTo(HaveOccurred())

By("Waiting for second the Certificate to be issued...")
cert2, err = f.Helper().WaitForCertificateReadyAndDoneIssuing(ctx, cert2, time.Minute*5)
Expect(err).NotTo(HaveOccurred())

By("Validating the issued Certificate...")
err = f.Helper().ValidateCertificate(cert, validations...)
Expect(err).NotTo(HaveOccurred())

By("Validating the second issued Certificate...")
err = f.Helper().ValidateCertificate(cert2, validations...)
Expect(err).NotTo(HaveOccurred())
})
It("should obtain a signed certificate with a single CN from the ACME server when redirected", func() {
certClient := f.CertManagerClientSet.CertmanagerV1().Certificates(f.Namespace.Name)

Expand Down