Add optional hostAliases to cert-manager pod

[Pionerd]

Pull Request Motivation

As a mitigation for #1292 it may be desired to hardcode DNS entries on pod level to allow the self-check to pass, e.g. in the scenario where the network does not allow traffic to an internal IP by calling its external IP (which happens in the case of a public DNS).

Kind

feature

Release Note

[Helm] Add optional hostAliases to cert-manager pod to allow the DNS self-check to pass in custom scenarios.

[jetstack-bot]

Hi @Pionerd. Thanks for your PR.

I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jetstack-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign joshvanl for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[adrianrobotka]

I would like to see this PR merged for a different reason:
I want to specify the hostAliases field due to personal/external motivation (e.g. using the Private Service Connect functionality on GCP without a private DNS resolver).

May I expect this to be merged in the foreseeable future?

[pawcykca]

@Pionerd Can you update this PR?

[cert-manager-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
/lifecycle stale

[pawcykca]

/remove-lifecycle stale

[SgtCoDFish]

/ok-to-test

[SgtCoDFish]

Hey, thanks for raising this and sorry it took a while to get eyes on it - pinging us in slack for a review is usually a good way to get our attention 😁

The tests will fail for this at the time I'm writing this comment because helm docs will need to be generated. Do you think we could update the comment a little too?

Happy to merge this once tests are passing!

[Pionerd]

/retest

[Pionerd]

I'm having some trouble getting the merge commit signed, any tips?

[SgtCoDFish]

/lgtm
/approve
/kind feature

Looks like you got it signed correctly! Thanks for your contribution, this is a great improvement 🚀

[cert-manager-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SgtCoDFish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [SgtCoDFish]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment