Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added yarn for installing Cerebral 2 edge #553

Closed
wants to merge 1 commit into from
Closed

Added yarn for installing Cerebral 2 edge #553

wants to merge 1 commit into from

Conversation

hipertracker
Copy link
Contributor

Added simpler yarn. It's already used by default in create-react-app, so it makes sense to use it also here.

Added simpler yarn. It's already used by default in create-react-app, so it makes sense to use it also here.
@coveralls
Copy link

coveralls commented Dec 14, 2016

Coverage Status

Coverage remained the same at 88.873% when pulling c2f6b66 on hipertracker:patch-1 into ec8ba3a on cerebral:master.

@henri-hulski
Copy link
Member

Yarn is optional in CRA.
And Yarn didn't work for me (yarnpkg/yarn#746).
It also has some more issues: facebook/create-react-app#1189.

So I think we should at least document both npm and yarn and make yarn optional.

Copy link
Member

@Guria Guria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yarn users knows how to substitute npm commands in instructions.
Moreover, I have tested it result sligtly changed in part what we get in package.json. We have to instruct users to have exact versions without range and tag names in their package.json.

@Guria Guria closed this Dec 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants