-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docker: use python3.8 by default #1938
Conversation
ansible 2.13.13 throws the following error with python 3.12.3: """ ERROR! Unknown error when attempting to call Galaxy at 'https://galaxy.ansible.com/api/': 'CustomHTTPSConnection' object has no attribute 'cert_file'. 'CustomHTTPSConnection' object has no attribute 'cert_file' """ So, this commit enables python 3.8 by default in docker container. Signed-off-by: Vallari Agrawal <val.agl002@gmail.com>
@@ -1,22 +1,28 @@ | |||
FROM ubuntu:latest | |||
ARG SSH_PRIVKEY_FILE=id_ed25519 | |||
ENV DEBIAN_FRONTEND=noninteractive | |||
RUN apt-get update | |||
RUN apt-get install -y software-properties-common | |||
RUN add-apt-repository ppa:deadsnakes/ppa -y |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry what are these packages?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the deadsnakes PPA is where old versions of Python for newer Ubuntu versions are maintained
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ahh i see, just knew this
This could definitely work - but 3.8 goes EOL in October. I just installed python 3.9 on teuthology.front; I filed #1939 as a draft so that we can test that possibility as well. |
Oh I see, why are we only moving up one version to python 3.9? Maybe then we can install python 3.11 or 3.12 because python 3.9 would go EOL in October next year: https://devguide.python.org/versions/#supported-versions |
Pasting a Tracker here: https://tracker.ceph.com/issues/65868 for reference |
I opened #1940 to migrate us to 3.10 as the minimal python version; let me know what you think of the approach! |
ansible 2.13.13 throws the following error with python 3.12.3:
ERROR! Unknown error when attempting to call Galaxy at 'https://galaxy.ansible.com/api/': 'CustomHTTPSConnection' object has no attribute 'cert_file'. 'CustomHTTPSConnection' object has no attribute 'cert_file'
We tried updating the ansible version (#1937) but ansible 2.14.x or later requires python >= 3.9. If we upgrade the ansible version from 2.13.13, then teuthology's support for python3.8 would end which could cause unpredictable problems.
So, this commit enables python 3.8 by default in docker container, instead of latest python3 version (3.12.3).