Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing nuke #1915

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Removing nuke #1915

wants to merge 5 commits into from

Conversation

zmc
Copy link
Member

@zmc zmc commented Feb 2, 2024

This PR removes the entire nuke system, save for clear_firewall() which is still used by tasks in ceph.git. It contains new implementations of node unlocking and cleanup to better reflect how we use machine resources.

This commit contains only full file deletions, and the relocation of
nuke.actions.clear_firewall() to nuke/__init__.py to retain compatibility with
older ceph.git tasks.

Signed-off-by: Zack Cerza <zack@redhat.com>
This commit contains trivial changes like reference removals, docs changes, and
removal of dead code.

Signed-off-by: Zack Cerza <zack@redhat.com>
This commit re-implements functionality that was removed with the nuke system.

Signed-off-by: Zack Cerza <zack@redhat.com>
This replaces teuthology-nuke --stale

Signed-off-by: Zack Cerza <zack@redhat.com>
docker-compose exits non-zero if a container goes down while it's running.

Signed-off-by: Zack Cerza <zack@redhat.com>
@zmc zmc requested a review from amathuria February 22, 2024 21:55
Copy link
Contributor

@amathuria amathuria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zmc this looks good to me! I was just wondering if maybe we should also add a reason for removing the nuke command? to the commit message or we can attach a tracker
For future reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants