Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task/selinux: Ignore source context of ping_t #1830

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

badone
Copy link
Contributor

@badone badone commented Mar 30, 2023

@badone badone requested a review from zmc March 31, 2023 06:59
@badone
Copy link
Contributor Author

badone commented Apr 19, 2023

Bump

@badone badone requested a review from dmick April 19, 2023 23:03
@dmick
Copy link
Member

dmick commented Apr 25, 2023

Dear God I hate selinux.

  1. does this not make the ping fail? Is that not an issue for the test?
  2. is this fix "ignoring the source context of ping_t", or is it ignoring a mismatch in source context for purposes of masking the error for teuthology?

@kshtsk
Copy link
Contributor

kshtsk commented Apr 26, 2023

rebase needed

Fixes: https://tracker.ceph.com/issues/55443

Signed-off-by: Brad Hubbard <bhubbard@redhat.com>
@badone
Copy link
Contributor Author

badone commented May 2, 2023

rebase needed

I've rebased my branch, although it's not clear at all that a rebase was needed and there were no conflicts.

@badone
Copy link
Contributor Author

badone commented May 2, 2023

Dear God I hate selinux.

1. does this not make the ping fail?  Is that not an issue for the test?

It's not clear what invokes the ping to me. The tests fail because the selinux denial is found in the logs. With this commit the tests pass. I think for whatever reason the powercycle tests invoke 'ping' indirectly.

2. is this fix "ignoring the source context of ping_t", or is it ignoring a _mismatch_ in source context for purposes of masking the error for teuthology?

I'm not sure what you mean exactly by mismatch. As the tracker indicates this appears to be a system problem which has not been resolved therefore I am asking teuthology to ignore this denial so the tests will pass.

@dmick
Copy link
Member

dmick commented May 2, 2023

What is the source context, and how does this change ignore it?

@badone badone force-pushed the wip-ignore-ping-selinux-denial-tracker-55443 branch from a6a4a7f to 9446fdb Compare May 3, 2023 23:38
@badone badone added the DNM label May 4, 2023
@badone
Copy link
Contributor Author

badone commented May 4, 2023

After talking to Dan I'm going to try and make this more specific.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants