s3select: Limit bug json #150
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix for json parser processing more chunks than specified in the limit Signed-off-by: Albin Antony <albinantony20@gmail.com>
albin-antony
force-pushed
the
limit-bug
branch
from
71e4031
to
4eb782c
Compare
| if(is_sql_limit_reached()) | ||
| { | ||
| status = JSON_PROCESSING_LIMIT_REACHED;//returning number since sql_execution_on_row_cb is a callback; the caller can not access the object | ||
| m_sql_processing_status = s3selectEngine::base_s3object::Status::LIMIT_REACHED; |
There was a problem hiding this comment.
reviewing function
is_sql_limit_reached
https://github.com/ceph/s3select/blob/4eb782c028d210f3af7407467ec878d2a84457d4/include/s3select.h#L2223C8-L2223C28
this line is obsolete.
|
|
||
| if(m_is_limit_on && m_row_count == m_limit) { | ||
| m_sql_processing_status = s3selectEngine::base_s3object::Status::LIMIT_REACHED; | ||
| } |
There was a problem hiding this comment.
|
this issue may relate to the from-clause functionality (scan for the next row) the scanner refers to keys that match the from-clause-pattern as an object or array. it should be fixed in #129 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for json parser processing more chunks than specified in the limit
https://bugzilla.redhat.com/show_bug.cgi?id=2242089