Reflect the correct Error code returned by S3 "NoSuchTagSetError"i #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tejas Chandramouli <tchandra@redhat.com>
cbodley
requested changes
Sep 27, 2023
| @@ -7797,7 +7797,7 @@ def test_set_bucket_tagging(): | |||
| e = assert_raises(ClientError, client.get_bucket_tagging, Bucket=bucket_name) | |||
| status, error_code = _get_status_and_error_code(e.response) | |||
| eq(status, 404) | |||
| eq(error_code, 'NoSuchTagSet') | |||
| eq(error_code, 'NoSuchTagSetError') | |||
There was a problem hiding this comment.
NoSuchTagSetError is not the correct error code. this was fixed for https://tracker.ceph.com/issues/55460, and the s3tests were changed to use the correct NoSuchTagSet in #452. that change is present on the ceph-quincy branch: 722c2a9
according to the quincy backport https://tracker.ceph.com/issues/55614, this was fixed in quincy v17.2.7. so earlier point releases are expected to fail on this test
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this should resolve seen on ceph-quincy
'FAIL: s3tests_boto3.functional.test_s3.test_set_bucket_tagging'
b' File "/home/cephuser/s3-tests/s3tests_boto3/functional/test_s3.py", line 7800, in test_set_bucket_tagging'
b" eq(error_code, 'NoSuchTagSet')"
b"AssertionError: 'NoSuchTagSetError' != 'NoSuchTagSet'"