Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc/cephfs: edit front matter in client-auth.rst #57119

Merged
merged 1 commit into from Apr 29, 2024

Conversation

zdover23
Copy link
Contributor

Clarify the front matter in doc/cephfs/client-auth.rst.

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

@zdover23 zdover23 requested a review from a team as a code owner April 28, 2024 13:20
@github-actions github-actions bot added cephfs Ceph File System documentation labels Apr 28, 2024
@@ -2,15 +2,15 @@
CephFS Client Capabilities
================================

Use Ceph authentication capabilities to restrict your file system clients
to the lowest possible level of authority needed.
Ceph authentication capabilities are used to restrict file system clients to
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CephFS

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good one.

.. note:: Path restriction and layout modification restriction are new features
in the Jewel release of Ceph.
.. note:: Path restriction and layout-modification restriction were introduced
in the Jewel release of Ceph.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we don’t care about Infernalis and earlier? Remove?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm on the fence about removing stuff like this.

The case for removing information about when features were introduced: this is a technical manual, meant to explain how to use Ceph. This is not a historical record of the development of Ceph.

The case against removing information about when features were introduced: It's nice to know when features were introduced, and gives a sense of Ceph as an ongoing concern that responds to the world in which it serves the ends of its users and developers.

be enabled on the data pools.
.. note:: Using Erasure Coded (EC) pools with CephFS is supported only with
:term:`BlueStore`. Erasure-coded pools cannot be used as metadata pools and
overwrites must be enabled on the data pools.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S/the//

Copy link
Contributor Author

@zdover23 zdover23 Apr 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with this change, but I think that we should do even more--this sentence should be split into two sentences. The way that it is now suggests that "overwrites" is the second item in a list that begins with "metadata pools", when in fact "overwrites" is the beginning of a second proposition, unrelated to the first.

@zdover23 zdover23 force-pushed the wip-doc-2024-04-28-cephfs-client-auth branch from 83f8792 to dc4fc8f Compare April 29, 2024 02:10
Clarify the front matter in doc/cephfs/client-auth.rst.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
@zdover23 zdover23 force-pushed the wip-doc-2024-04-28-cephfs-client-auth branch from dc4fc8f to 713c730 Compare April 29, 2024 02:18
@zdover23 zdover23 merged commit 923e8c0 into ceph:main Apr 29, 2024
11 checks passed
@zdover23
Copy link
Contributor Author

#57121 - Squid backport
#57122 - Reef backport
#57123 - Quincy backport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cephfs Ceph File System documentation
Projects
None yet
2 participants