Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reef: mds: fix the description for inotable testing only options #57115

Open
wants to merge 1 commit into
base: reef
Choose a base branch
from
Open

reef: mds: fix the description for inotable testing only options #57115

wants to merge 1 commit into from

Conversation

lxbsz
Copy link
Member

@lxbsz lxbsz commented Apr 28, 2024

backport tracker: https://tracker.ceph.com/issues/65676

backport of #52024
parent tracker: https://tracker.ceph.com/issues/61660

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

@lxbsz
mds: fix the description for inotable testing only options
2bcd34f 
The description text are mixed for mds_kill_skip_replaying_inotable
and mds_inject_skip_replaying_inotable.

At the same time rename "mds_kill_skip_replaying_inotable", which
is a bit confusing to "mds_kill_after_journal_logs_flushed".

Fixes: https://tracker.ceph.com/issues/61660
Signed-off-by: Xiubo Li <xiubli@redhat.com>
(cherry picked from commit 7df5714)
@lxbsz lxbsz requested a review from a team April 28, 2024 01:11
@lxbsz lxbsz requested a review from a team as a code owner April 28, 2024 01:11
@github-actions github-actions bot added this to the reef milestone Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leonid-s-usov leonid-s-usov leonid-s-usov approved these changes

@anthonyeleven anthonyeleven anthonyeleven approved these changes

Assignees
No one assigned
Labels
cephfs Ceph File System common documentation tests
Projects
None yet
Milestone
reef
3 participants
@lxbsz @leonid-s-usov @anthonyeleven